From: Hans de Goede <hdegoede@redhat.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Wolfram Sang <wsa@kernel.org>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/12] platform/x86: intel_cht_int33fe_microb: Constify the software node
Date: Mon, 29 Mar 2021 17:27:53 +0200 [thread overview]
Message-ID: <6d4d44d5-c213-1052-16a6-833a7f01a0ee@redhat.com> (raw)
In-Reply-To: <20210329105047.51033-7-heikki.krogerus@linux.intel.com>
Hi,
On 3/29/21 12:50 PM, Heikki Krogerus wrote:
> Additional device properties are always just a part of a
> software fwnode. If the device properties are constant, the
> software node can also be constant.
>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Cc: Hans de Goede <hdegoede@redhat.com>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
What is the plan for merging this patch / this series ?
Regards,
Hans
> ---
> drivers/platform/x86/intel_cht_int33fe_microb.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel_cht_int33fe_microb.c b/drivers/platform/x86/intel_cht_int33fe_microb.c
> index 20b11e0d9a758..673f41cd14b52 100644
> --- a/drivers/platform/x86/intel_cht_int33fe_microb.c
> +++ b/drivers/platform/x86/intel_cht_int33fe_microb.c
> @@ -35,6 +35,10 @@ static const struct property_entry bq27xxx_props[] = {
> { }
> };
>
> +static const struct software_node bq27xxx_node = {
> + .properties = bq27xxx_props,
> +};
> +
> int cht_int33fe_microb_probe(struct cht_int33fe_data *data)
> {
> struct device *dev = data->dev;
> @@ -43,7 +47,7 @@ int cht_int33fe_microb_probe(struct cht_int33fe_data *data)
> memset(&board_info, 0, sizeof(board_info));
> strscpy(board_info.type, "bq27542", ARRAY_SIZE(board_info.type));
> board_info.dev_name = "bq27542";
> - board_info.properties = bq27xxx_props;
> + board_info.swnode = &bq27xxx_node;
> data->battery_fg = i2c_acpi_new_device(dev, 1, &board_info);
>
> return PTR_ERR_OR_ZERO(data->battery_fg);
>
next prev parent reply other threads:[~2021-03-29 15:28 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 10:50 [PATCH 00/12] i2c: Adding support for software nodes Heikki Krogerus
2021-03-29 10:50 ` [PATCH 01/12] i2c: Add " Heikki Krogerus
2021-03-29 10:50 ` [PATCH 02/12] ARM: davinci: Constify the " Heikki Krogerus
2021-04-06 19:38 ` Wolfram Sang
2021-04-07 7:41 ` Bartosz Golaszewski
2021-03-29 10:50 ` [PATCH 03/12] ARM: omap1: osk: Constify the software node Heikki Krogerus
2021-03-31 6:15 ` Tony Lindgren
2021-03-29 10:50 ` [PATCH 04/12] ARM: pxa: stargate2: " Heikki Krogerus
2021-04-06 19:39 ` Wolfram Sang
2021-04-10 8:16 ` Robert Jarzmik
2021-03-29 10:50 ` [PATCH 05/12] ARM: s3c: mini2440: " Heikki Krogerus
2021-03-29 10:58 ` Krzysztof Kozlowski
2021-03-29 12:32 ` Heikki Krogerus
2021-04-01 17:44 ` Krzysztof Kozlowski
2021-04-06 19:40 ` Wolfram Sang
2021-04-06 20:28 ` Krzysztof Kozlowski
2021-03-29 10:50 ` [PATCH 06/12] platform/x86: intel_cht_int33fe_microb: " Heikki Krogerus
2021-03-29 15:27 ` Hans de Goede [this message]
2021-04-06 19:40 ` Wolfram Sang
2021-04-06 19:49 ` Hans de Goede
2021-03-29 10:50 ` [PATCH 07/12] i2c: cht-wc: " Heikki Krogerus
2021-03-29 15:28 ` Hans de Goede
2021-03-29 10:50 ` [PATCH 08/12] i2c: nvidia-gpu: " Heikki Krogerus
2021-03-29 10:50 ` [PATCH 09/12] i2c: icy: " Heikki Krogerus
2021-03-30 13:58 ` Max Staudt
2021-04-08 21:22 ` Wolfram Sang
2021-04-08 22:13 ` Max Staudt
2021-03-29 10:50 ` [PATCH 10/12] platform/chrome: chromeos_laptop - Prepare complete software nodes Heikki Krogerus
2021-03-30 16:33 ` Enric Balletbo i Serra
2021-03-29 10:50 ` [PATCH 11/12] Input: elantech - Prepare a complete software node for the device Heikki Krogerus
2021-03-29 19:05 ` Dmitry Torokhov
2021-03-29 10:50 ` [PATCH 12/12] i2c: Remove support for dangling device properties Heikki Krogerus
2021-03-31 9:22 ` [PATCH 00/12] i2c: Adding support for software nodes Wolfram Sang
2021-03-31 10:17 ` Heikki Krogerus
2021-04-06 19:37 ` Wolfram Sang
2021-04-08 21:53 ` Wolfram Sang
2021-04-09 9:39 ` Heikki Krogerus
2021-04-10 19:48 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d4d44d5-c213-1052-16a6-833a7f01a0ee@redhat.com \
--to=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).