From: Xiubo Li <xiubli@redhat.com>
To: "Luís Henriques" <lhenriques@suse.de>
Cc: Jeff Layton <jlayton@kernel.org>,
Ilya Dryomov <idryomov@gmail.com>,
ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ceph: invalidate pages when doing DIO in encrypted inodes
Date: Wed, 6 Apr 2022 18:57:02 +0800 [thread overview]
Message-ID: <6d8df20e-d99a-0f80-f3e1-3c661351759c@redhat.com> (raw)
In-Reply-To: <87fsmqa3jj.fsf@brahms.olymp>
On 4/6/22 6:50 PM, Luís Henriques wrote:
> Xiubo Li <xiubli@redhat.com> writes:
>
>> On 4/1/22 9:32 PM, Luís Henriques wrote:
>>> When doing DIO on an encrypted node, we need to invalidate the page cache in
>>> the range being written to, otherwise the cache will include invalid data.
>>>
>>> Signed-off-by: Luís Henriques <lhenriques@suse.de>
>>> ---
>>> fs/ceph/file.c | 11 ++++++++++-
>>> 1 file changed, 10 insertions(+), 1 deletion(-)
>>>
>>> Changes since v1:
>>> - Replaced truncate_inode_pages_range() by invalidate_inode_pages2_range
>>> - Call fscache_invalidate with FSCACHE_INVAL_DIO_WRITE if we're doing DIO
>>>
>>> Note: I'm not really sure this last change is required, it doesn't really
>>> affect generic/647 result, but seems to be the most correct.
>>>
>>> diff --git a/fs/ceph/file.c b/fs/ceph/file.c
>>> index 5072570c2203..b2743c342305 100644
>>> --- a/fs/ceph/file.c
>>> +++ b/fs/ceph/file.c
>>> @@ -1605,7 +1605,7 @@ ceph_sync_write(struct kiocb *iocb, struct iov_iter *from, loff_t pos,
>>> if (ret < 0)
>>> return ret;
>>> - ceph_fscache_invalidate(inode, false);
>>> + ceph_fscache_invalidate(inode, (iocb->ki_flags & IOCB_DIRECT));
>>> ret = invalidate_inode_pages2_range(inode->i_mapping,
>>> pos >> PAGE_SHIFT,
>>> (pos + count - 1) >> PAGE_SHIFT);
>>> @@ -1895,6 +1895,15 @@ ceph_sync_write(struct kiocb *iocb, struct iov_iter *from, loff_t pos,
>>> req->r_inode = inode;
>>> req->r_mtime = mtime;
>>> + if (IS_ENCRYPTED(inode) && (iocb->ki_flags & IOCB_DIRECT)) {
>>> + ret = invalidate_inode_pages2_range(
>>> + inode->i_mapping,
>>> + write_pos >> PAGE_SHIFT,
>>> + (write_pos + write_len - 1) >> PAGE_SHIFT);
>>> + if (ret < 0)
>>> + dout("invalidate_inode_pages2_range returned %d\n", ret);
>>> + }
>> Shouldn't we fail it if the 'invalidate_inode_pages2_range()' fails here ?
> Yeah, I'm not really sure. I'm simply following the usual pattern where
> an invalidate_inode_pages2_range() failure is logged and ignored. And
> this is not ceph-specific, other filesystems seem to do the same thing.
I think it should be they are using this to invalidate the range only,
do not depend on it to writeback the dirty pages.
Such as they may will call 'filemap_fdatawrite_range()', etc.
I saw in the beginning of the 'ceph_sync_write()', it will do
'filemap_write_and_wait_range()' too. So the dirty pages should have
already flushed.
-- Xiubo
> Cheers,
next prev parent reply other threads:[~2022-04-06 14:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 13:32 [PATCH v2] ceph: invalidate pages when doing DIO in encrypted inodes Luís Henriques
2022-04-06 5:24 ` Xiubo Li
2022-04-06 10:50 ` Luís Henriques
2022-04-06 10:57 ` Xiubo Li [this message]
2022-04-06 6:28 ` Xiubo Li
2022-04-06 10:57 ` Luís Henriques
2022-04-06 11:18 ` Xiubo Li
2022-04-06 11:33 ` Luís Henriques
2022-04-06 11:48 ` Jeff Layton
2022-04-06 13:10 ` Xiubo Li
2022-04-06 13:41 ` Jeff Layton
2022-04-07 1:17 ` Xiubo Li
2022-04-07 11:55 ` Luís Henriques
2022-04-07 13:23 ` Jeff Layton
2022-04-07 14:08 ` Jeff Layton
2022-04-07 3:19 ` Xiubo Li
2022-04-07 9:06 ` Luís Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d8df20e-d99a-0f80-f3e1-3c661351759c@redhat.com \
--to=xiubli@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=lhenriques@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).