From: Marc Zyngier <maz@kernel.org>
To: Valentin Schneider <valentin.schneider@arm.com>
Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>
Subject: Re: [PATCH 0/2] genirq: Kill preflow handlers
Date: Sat, 04 Jul 2020 10:48:57 +0100 [thread overview]
Message-ID: <6d902159f1819b6f3a0af5e982d11868@kernel.org> (raw)
In-Reply-To: <20200703155645.29703-1-valentin.schneider@arm.com>
Hi Valentin,
On 2020-07-03 16:56, Valentin Schneider wrote:
> Hi,
>
> while strolling around the different flow handlers, I tried to make
> sense of
> what preflow_handler() was about. Turns out no one uses those anymore,
> but the
> genirq support has remained in place.
If we needed to reintroduce some form of preflow handler, we'd try and
do it using hierarchical irqchips, if at all possible.
>
> Unless we can see another user of those in the near future, this seems
> like as
> good a time as any for a little housecleaning.
>
> - Patch 1 simply deselects the (unexploited) preflow Kconfig for
> sparc64
> - Patch 2 is the actual cleanup
>
> Cheers,
> Valentin
>
> Valentin Schneider (2):
> sparc64: Deselect IRQ_PREFLOW_FASTEOI
> genirq: Remove preflow handler support
>
> arch/sparc/Kconfig | 1 -
> include/linux/irqdesc.h | 15 ---------------
> include/linux/irqhandler.h | 1 -
> kernel/irq/Kconfig | 4 ----
> kernel/irq/chip.c | 13 -------------
> 5 files changed, 34 deletions(-)
For the whole series, and assuming that there is no regression
(can't imagine any for unused code):
Reviewed-by: Marc Zyngier <maz@kernel.org>
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2020-07-04 9:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 15:56 [PATCH 0/2] genirq: Kill preflow handlers Valentin Schneider
2020-07-03 15:56 ` [PATCH 1/2] sparc64: Deselect IRQ_PREFLOW_FASTEOI Valentin Schneider
2020-07-03 16:29 ` Anatoly Pugachev
2020-07-04 8:05 ` [tip: irq/core] " tip-bot2 for Valentin Schneider
2020-07-22 1:29 ` [PATCH 1/2] " David Miller
2020-07-03 15:56 ` [PATCH 2/2] genirq: Remove preflow handler support Valentin Schneider
2020-07-04 8:05 ` [tip: irq/core] " tip-bot2 for Valentin Schneider
2020-07-04 9:48 ` Marc Zyngier [this message]
2020-07-04 23:51 ` [PATCH 0/2] genirq: Kill preflow handlers Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d902159f1819b6f3a0af5e982d11868@kernel.org \
--to=maz@kernel.org \
--cc=davem@davemloft.net \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=valentin.schneider@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).