From: Gao Xiang <gaoxiang25@huawei.com>
To: Aaron Strahlberger <aaron.strahlberger@posteo.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Chao Yu <yuchao0@huawei.com>, <linux-erofs@lists.ozlabs.org>,
<devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>,
<linux-kernel@i4.cs.fau.de>,
Julius Wiedmann <julius.wiedmann@fau.de>,
Dominik Huber <domi250@gmx.de>
Subject: Re: [PATCH v2] staging:erofs: Remove __EROFS_BIT macro
Date: Wed, 12 Dec 2018 20:18:05 +0800 [thread overview]
Message-ID: <6db43c9b-f668-167c-cc08-b19689329a27@huawei.com> (raw)
In-Reply-To: <20181212120209.16304-1-aaron.strahlberger@posteo.de>
Hi Aaron,
On 2018/12/12 20:02, Aaron Strahlberger wrote:
> The `__EROFS_BIT` macro is used only once, do define the
> `EROFS_I_DATA_MAPPING_BIT` constant. This Patch removes this
> macro and expands it in the place it is used.
>
> Signed-off-by: Aaron Strahlberger <aaron.strahlberger@posteo.de>
> Signed-off-by: Julius Wiedmann <julius.wiedmann@fau.de>
> Signed-off-by: Dominik Huber <domi250@gmx.de>
> ---
> drivers/staging/erofs/erofs_fs.h | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
> +
> #define EROFS_I_VERSION_BITS 1
> #define EROFS_I_DATA_MAPPING_BITS 3
>
> #define EROFS_I_VERSION_BIT 0
> -__EROFS_BIT(EROFS_I_, DATA_MAPPING, VERSION);
> +enum {
> + EROFS_I_DATA_MAPPING_BIT = EROFS_I_VERSION_BIT + EROFS_I_VERSION_BITS
> +}
Thanks for your patch. I have fixed it yesterday,
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/commit/drivers/staging/erofs?h=staging-testing&id=ccd9c19c7ae165c70221b0a4927c31a56e395658
EROFS_I_DATA_MAPPING_BIT = EROFS_I_VERSION_BIT + EROFS_I_VERSION_BITS is not straight-forward as well for erofs on-disk format definition,
fix it to a plain number.
Thanks,
Gao Xiang
>
> struct erofs_inode_v1 {
> /* 0 */__le16 i_advise;
>
next prev parent reply other threads:[~2018-12-12 12:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 9:06 [PATCH] drivers: staging: erofs: Fix styling issues Aaron Strahlberger
2018-12-11 9:18 ` Gao Xiang
2018-12-11 10:54 ` [PATCH 0/5] " Aaron Strahlberger
2018-12-11 10:54 ` [PATCH 1/5] drivers: staging: erofs: Fix alignment Aaron Strahlberger
2018-12-11 11:19 ` Gao Xiang
2018-12-11 13:00 ` Dan Carpenter
2018-12-11 10:54 ` [PATCH 2/5] drivers: staging: erofs: Fix comparison to NULL issues Aaron Strahlberger
2018-12-11 11:22 ` Gao Xiang
2018-12-11 10:54 ` [PATCH 3/5] drivers: staging: erofs: Fix spelling issue Aaron Strahlberger
2018-12-11 11:27 ` Gao Xiang
2018-12-11 10:54 ` [PATCH 4/5] drivers: staging: erofs: Fix parentheses error in macro Aaron Strahlberger
2018-12-11 11:06 ` Gao Xiang
2018-12-11 15:48 ` Joe Perches
2018-12-11 17:05 ` Gao Xiang
2018-12-12 12:02 ` [PATCH v2] staging:erofs: Remove __EROFS_BIT macro Aaron Strahlberger
2018-12-12 12:18 ` Gao Xiang [this message]
2018-12-11 10:54 ` [PATCH 5/5] drivers: staging: erofs: Add blank line after function Aaron Strahlberger
2018-12-12 12:00 ` [PATCH v2] staging:erofs: Fix alignment issues Aaron Strahlberger
2018-12-12 12:11 ` Gao Xiang
2018-12-12 12:29 ` Gao Xiang
2018-12-11 12:51 ` [PATCH] drivers: staging: erofs: Fix styling issues Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6db43c9b-f668-167c-cc08-b19689329a27@huawei.com \
--to=gaoxiang25@huawei.com \
--cc=aaron.strahlberger@posteo.de \
--cc=devel@driverdev.osuosl.org \
--cc=domi250@gmx.de \
--cc=gregkh@linuxfoundation.org \
--cc=julius.wiedmann@fau.de \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).