* [PATCH -next] rtc: m41t80: correct function names in rtc-m41t80.c
@ 2021-05-17 4:58 Yang Yingliang
2021-05-17 5:07 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2021-05-17 4:58 UTC (permalink / raw)
To: linux-kernel, linux-rtc; +Cc: a.zummo, alexandre.belloni
Fix the following make W=1 kernel build warnings:
drivers/rtc/rtc-m41t80.c:811: warning: expecting prototype for wdt_close(). Prototype was for wdt_release() instead
drivers/rtc/rtc-m41t80.c:830: warning: expecting prototype for notify_sys(). Prototype was for wdt_notify_sys() instead
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/rtc/rtc-m41t80.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c
index 89128fc29ccc..79512d1c828e 100644
--- a/drivers/rtc/rtc-m41t80.c
+++ b/drivers/rtc/rtc-m41t80.c
@@ -802,7 +802,7 @@ static int wdt_open(struct inode *inode, struct file *file)
}
/**
- * wdt_close:
+ * wdt_release:
* @inode: inode to board
* @file: file handle to board
*
@@ -815,7 +815,7 @@ static int wdt_release(struct inode *inode, struct file *file)
}
/**
- * notify_sys:
+ * wdt_notify_sys:
* @this: our notifier block
* @code: the event being reported
* @unused: unused
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] rtc: m41t80: correct function names in rtc-m41t80.c
2021-05-17 4:58 [PATCH -next] rtc: m41t80: correct function names in rtc-m41t80.c Yang Yingliang
@ 2021-05-17 5:07 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2021-05-17 5:07 UTC (permalink / raw)
To: Yang Yingliang, linux-kernel, linux-rtc; +Cc: a.zummo, alexandre.belloni
On 5/16/21 9:58 PM, Yang Yingliang wrote:
> Fix the following make W=1 kernel build warnings:
>
> drivers/rtc/rtc-m41t80.c:811: warning: expecting prototype for wdt_close(). Prototype was for wdt_release() instead
> drivers/rtc/rtc-m41t80.c:830: warning: expecting prototype for notify_sys(). Prototype was for wdt_notify_sys() instead
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Hi,
In kernel-doc notation, a function name should be followed by a '-',
not a ':'. Please fix & resend.
Thanks.
> ---
> drivers/rtc/rtc-m41t80.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c
> index 89128fc29ccc..79512d1c828e 100644
> --- a/drivers/rtc/rtc-m41t80.c
> +++ b/drivers/rtc/rtc-m41t80.c
> @@ -802,7 +802,7 @@ static int wdt_open(struct inode *inode, struct file *file)
> }
>
> /**
> - * wdt_close:
> + * wdt_release:
> * @inode: inode to board
> * @file: file handle to board
> *
> @@ -815,7 +815,7 @@ static int wdt_release(struct inode *inode, struct file *file)
> }
>
> /**
> - * notify_sys:
> + * wdt_notify_sys:
> * @this: our notifier block
> * @code: the event being reported
> * @unused: unused
>
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-17 5:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-17 4:58 [PATCH -next] rtc: m41t80: correct function names in rtc-m41t80.c Yang Yingliang
2021-05-17 5:07 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).