From: Florian Fainelli <f.fainelli@gmail.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>,
linux-kernel@vger.kernel.org
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
Brian Norris <computersforpeace@gmail.com>,
Gregory Fong <gregory.0xf0@gmail.com>,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH-next] reset: brcmstb: make it explicitly non-modular
Date: Tue, 22 Jan 2019 14:54:30 -0800 [thread overview]
Message-ID: <6dc84f3e-94c9-7bcd-1140-a76d64b5fa9d@gmail.com> (raw)
In-Reply-To: <1548183727-5073-1-git-send-email-paul.gortmaker@windriver.com>
On 1/22/19 11:02 AM, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
>
> drivers/reset/Kconfig: bool "Broadcom STB reset controller" if COMPILE_TEST
> drivers/reset/Kconfig: default ARCH_BRCMSTB
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the couple traces of modular infrastructure use, so that
> when reading the driver there is no doubt it is builtin-only.
>
> Since module_platform_driver() uses the same init level priority as
> builtin_platform_driver() the init ordering remains unchanged with
> this commit.
>
> We also delete no-op MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Brian Norris <computersforpeace@gmail.com>
> Cc: Gregory Fong <gregory.0xf0@gmail.com>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: bcm-kernel-feedback-list@broadcom.com
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
>
> [Driver just recently appeared in linux-next - if rebasing, feel free
> to squash this change into the original commit. Or make it tristate?]
I would rather make it tristate indeed, there is another change I need
to submit, thanks!
>
> drivers/reset/reset-brcmstb.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/reset/reset-brcmstb.c b/drivers/reset/reset-brcmstb.c
> index 01ab1f71518b..5bc0c74cf97c 100644
> --- a/drivers/reset/reset-brcmstb.c
> +++ b/drivers/reset/reset-brcmstb.c
> @@ -8,7 +8,7 @@
> #include <linux/delay.h>
> #include <linux/device.h>
> #include <linux/io.h>
> -#include <linux/module.h>
> +#include <linux/init.h>
> #include <linux/of.h>
> #include <linux/platform_device.h>
> #include <linux/reset-controller.h>
> @@ -123,8 +123,4 @@ static struct platform_driver brcmstb_reset_driver = {
> .of_match_table = brcmstb_reset_of_match,
> },
> };
> -module_platform_driver(brcmstb_reset_driver);
> -
> -MODULE_AUTHOR("Broadcom");
> -MODULE_DESCRIPTION("Broadcom STB reset controller");
> -MODULE_LICENSE("GPL");
> +builtin_platform_driver(brcmstb_reset_driver);
>
--
Florian
prev parent reply other threads:[~2019-01-22 22:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 19:02 [PATCH-next] reset: brcmstb: make it explicitly non-modular Paul Gortmaker
2019-01-22 22:54 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6dc84f3e-94c9-7bcd-1140-a76d64b5fa9d@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=computersforpeace@gmail.com \
--cc=gregory.0xf0@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).