From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751798AbdFORCE (ORCPT <rfc822;w@1wt.eu>);
        Thu, 15 Jun 2017 13:02:04 -0400
Received: from smtp-out-no.shaw.ca ([64.59.134.9]:49618 "EHLO
        smtp-out-no.shaw.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750830AbdFORCD (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 15 Jun 2017 13:02:03 -0400
X-Authority-Analysis: v=2.2 cv=a+JAzQaF c=1 sm=1 tr=0
 a=JyAt4amVi6RK7kaaDbhaBA==:117 a=JyAt4amVi6RK7kaaDbhaBA==:17
 a=IkcTkHD0fZMA:10 a=LWSFodeU3zMA:10 a=EQuHl_eTxhdzIYW10EIA:9 a=QEXdDO2ut3YA:10
Subject: Re: [PATCH v2] PCI: Add ATS-disable quirk for AMD Stoney GPUs
To: Joerg Roedel <jroedel@suse.de>, Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
        Daniel Drake <drake@endlessm.com>,
        Alexander Deucher <Alexander.Deucher@amd.com>,
        David Woodhouse <dwmw2@infradead.org>
References: <1491575538-22694-1-git-send-email-joro@8bytes.org>
 <20170615140421.GB25710@suse.de>
From: Samuel Sieb <samuel@sieb.net>
Message-ID: <6dd9dbac-9b65-bc7c-bb08-413a05d09fc8@sieb.net>
Date: Thu, 15 Jun 2017 10:01:53 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.0
MIME-Version: 1.0
In-Reply-To: <20170615140421.GB25710@suse.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-CMAE-Envelope: MS4wfOtPaR8rptsPjVTnZouxRFGHlprSCO7YRyrzdXZMBSy4TZeyPAyOZMN9uKI89NzznH7x5xoIr/eajYYuM71pE25vQBEIqIbc7K1t/heLXqD2yk16+wVe
 fzjBHdOQtmUai2p1/1ErXoStXIPF8Vgi5s49vc1XtLzclBIAvf42iuV25NS0ryHukpHOJC0gH6vxWclrcUZjS7XWNjIpDwYXeMBTKYE+gkXBRQeX2AcACJVk
 1JUJwMjj9JXUyVrM1vgsb0QZa6/AHJSoEUInLJnyf28HnqUBbZrA7x65PkGYxFRBkAgFHP+id5tev9q8Jw6tip2vez7ggfZfoCXJNO/xFqe2P4l8rG3ns+CT
 ktcjmoC4
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/15/2017 07:04 AM, Joerg Roedel wrote:
> Hi Bjorn,
> 
> On Fri, Apr 07, 2017 at 04:32:18PM +0200, Joerg Roedel wrote:
>> From: Joerg Roedel <jroedel@suse.de>
>>
>> ATS is broken on this hardware and causes IOMMU stalls and
>> system failure. Disable ATS on these devices to make them
>> usable again with IOMMU enabled.
>>
>> Note that the commit in the Fixes-tag is not buggy, it
>> just uncovers the problem in the hardware by increasing
>> the ATS-flush rate.
>>
>> Fixes: b1516a14657a ('iommu/amd: Implement flush queue')
>> Signed-off-by: Joerg Roedel <jroedel@suse.de>
>> ---
>>   drivers/pci/quirks.c | 19 +++++++++++++++++++
>>   1 file changed, 19 insertions(+)
> 
> Any more objections on this patch? Please let me know if you want to
> have something changed.

The other patch seems to fix this issue without disabling ATS.  Isn't 
that better?