From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: <dmaengine@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 2/3] dmaengine: add peripheral configuration
Date: Mon, 12 Oct 2020 15:05:09 +0300 [thread overview]
Message-ID: <6ddaa8c1-0703-4910-f5a8-2e30bddd2642@ti.com> (raw)
In-Reply-To: <20201012060916.GI2968@vkoul-mobl>
On 12/10/2020 9.09, Vinod Koul wrote:
> On 09-10-20, 14:29, Peter Ujfalusi wrote:
>>
>>
>> On 09/10/2020 14.15, Vinod Koul wrote:
>>>>> If for any any reason subsequent txn is for different direction, I would
>>>>> expect that parameters are set again before prep_ calls
>>>>
>>>> But in DEV_TO_DEV?
>>>
>>> Do we support that :D
>>>
>>>> If we have two peripherals, both needs config:
>>>> p1_config and p2_config
>>>>
>>>> What and how would one use the single peripheral_config?
>>>
>>> Since the config is implementation specific, I do not think it limits.
>>> You may create
>>>
>>> struct peter_config {
>>> struct p1_config;
>>> struct p2_config;
>>> };
>>
>> The use case is:
>> MEM -DMA-> P1 -DMA-> P2
>> or
>> P2 -DMA-> P1 -DMA-> MEM
>> or
>> MEM -DMA-> P2
>> or
>> P2 -DMA-> MEM
>> or
>> MEM -DMA-> P1 -DMA-> MEM
>>
>> How would the DMA guess what it should do? How would the independent P1
>> and P2 would know how to set up the config?
>
> As I said, we do not support DEV_TO_DEV yet :)
>
> Question is how would p1<-->p2 look, will p1 initiate a DMA txn or p2..?
> who will configure these..
That's a good question, I have not really thought about that.
If we have MEM in the picture, then it is a bit cleaner, but I would guess.
> Do you have a real world example in horizon...
In j721e we have AASRC module which needs special PDMA configuration to
match with it's setup, AASRC can be chained with McASP, which in turn
have different type of PDMA.
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2020-10-12 12:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 12:31 [PATCH v4 0/3] dmaengine: Add support for QCOM GSI dma controller Vinod Koul
2020-10-08 12:31 ` [PATCH v4 1/3] dt-bindings: dmaengine: Document qcom,gpi dma binding Vinod Koul
2020-10-12 18:57 ` Rob Herring
2020-10-13 7:02 ` Vinod Koul
2020-10-08 12:31 ` [PATCH v4 2/3] dmaengine: add peripheral configuration Vinod Koul
2020-10-09 9:04 ` Peter Ujfalusi
2020-10-09 10:30 ` Vinod Koul
2020-10-09 10:45 ` Peter Ujfalusi
2020-10-09 11:15 ` Vinod Koul
2020-10-09 11:29 ` Peter Ujfalusi
2020-10-12 6:09 ` Vinod Koul
2020-10-12 12:05 ` Peter Ujfalusi [this message]
2020-10-08 12:31 ` [PATCH v4 3/3] dmaengine: qcom: Add GPI dma driver Vinod Koul
2020-10-09 9:00 ` Peter Ujfalusi
2020-10-09 10:31 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ddaa8c1-0703-4910-f5a8-2e30bddd2642@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).