From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751131AbdJBLc3 (ORCPT ); Mon, 2 Oct 2017 07:32:29 -0400 Received: from mail-cys01nam02on0073.outbound.protection.outlook.com ([104.47.37.73]:37856 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750978AbdJBLc1 (ORCPT ); Mon, 2 Oct 2017 07:32:27 -0400 Cc: brijesh.singh@amd.com, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , kvm@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/CPU/AMD, mm: Extend with mem_encrypt=sme option To: Borislav Petkov References: <20171001171617.uzwfzps7sxowfram@pd.tnic> <20171001194509.4187-1-brijesh.singh@amd.com> <20171001220216.nhwc5momrn7wq3kj@pd.tnic> From: Brijesh Singh Message-ID: <6de5cc08-0a0d-cb45-9518-e5b30fd7e276@amd.com> Date: Mon, 2 Oct 2017 06:32:18 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171001220216.nhwc5momrn7wq3kj@pd.tnic> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [70.112.153.56] X-ClientProxiedBy: MWHPR13CA0024.namprd13.prod.outlook.com (10.169.208.34) To BY2PR12MB0148.namprd12.prod.outlook.com (10.162.82.21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 131955fe-3a31-4ad4-b3e3-08d5098940ae X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:BY2PR12MB0148; X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0148;3:4dDEdRVd+Cisq2KErm1dDGZZfwTFhMm32QC3F7NERvxEy2R1ZVyAJ1fPPOZ0WYOlJi6MxTba302wG1pdu/NtUs4bYfX/LAG9yIl5ountxueGB7/gHHeqHCpL95fudito2hEwlQq20uS+b4Un4KlMYmfGJxmpnH/dEFk5K6VacXA8hbLu4xcCTHogWyNy1hFpulyxG2DKQFx211NRIFjc/9uehupOM4fW4lVjP3Zg53s0u4fl8r6Exb5nu1CoP/Wm;25:DkT2qkozFdWPPSk5EnV9JCiRB6+lvLVKzdora0TSc9+FDxNqfSDQojB/Vh+MBOVkK+v6vh1Om1Y6IwOslIW/fa1tcEJ0NsXWXOi6K2/RYQdcP1u7D3nPN1bFZ8mRMG5FRX3seUY9yWicu78EEsRD/ROFT02yMEdJbKzXYaur+jPTkKOgRQG9dxTCCRX3jljNp7zGNwML7+p0tWQCGSVA+LySPloe9tGXM4BBkQZnskK+rp1RAZTHzqGNEtnDILCghc/h4yhxu43QYKPK2Z6x5slmVSBZYxn4IMQeI8BHdRn+pKhX+Akc8VwdnguwiX800GV+34PTJmkpuRQYCb5tAA==;31:JCWb5qUDFg4lbVE9RRC0mAsLzifvfdFxYWbkABw9IxC/fzVvjZru0Ouefam7ekr1LsJqGdkXVJK/PYjgFm/GZFVvAytz6kLOITg1caIUanZdtHsgdYcM2gTdxUaxDHOGLTGuWAD5tb3aaI6JG7J36U923YcPkR3PNK/akAQM0aTUPfEYv4MJPnb4QO5U6wk0VqG5DbfMA37eJBsHqbtaISutPSowa2UlgRZnpO3r/sk= X-MS-TrafficTypeDiagnostic: BY2PR12MB0148: X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0148;20:6vvSxeY+wxBQ3I1q6nEoIqodusaNunrPpkNkjNVuUEsOAXP0XT6NCXJhXRqfNlMe8hybEEcx+PgOO1g5+WTDdNbnSSFc1GcIOglZ3aogd8GQAszSBMYFm4Vc8BU/4rj26+hWxXWlqFKdLWK/PZm9PSPMttZ4EeXvsoezlY40zXmKMEmQRl9SfiroDHVBVVBfP/Lwzg4oY0jmAl+EwyzTCFazLfMG4nIUNvxLk2jswQS1D1saq0caZObb/umhU9RzYRgzBILVZ2ooaHAv8P3eHgOJCtlhBYnWqWR+ApEbQqNyFjLx6xoN1pp3ikn8BYnkbK6dUBEDA54B9G1i32kI/kKu9EEop4O4C5Q81lt5Yetfk6fyGZcxTSbHTdyVttnIQPUfy3/tQVfP1MB0AxZTqBSvE22gVhteskAY1F3FDg7YMSurZCtOPd55h0KDypHuNCMKBHYhMVwTuqf/H1vagxkEos2uDF7fbfQZm3TmvOZ4a3XbeRhs3JEooa2f+3X+;4:aTRCmBSO8waf1EgaT5UExRBtvZwo+XAGEVkSWhH+Xo8R1LcN6cF/5ufgxcvzMp+VsKLBNFjFMj862G8hou0I1CqUqIXvRYmIGj5WFyzINWTyIzCMFlpdLfZQELoos7d3yZRkSSbFn/kTkNWX5nahxWAkYHMeyGdCTK22S8s912s99t0AvM9Ol27lpJpuGx/2/T+//MRfkX0pLBVUs4Z96FpKnP8PrGPT9xgUXTjsuuGpnZ+xPuNcENNgi3p91C3Y X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(3002001)(6055026)(6041248)(20161123560025)(20161123558100)(20161123555025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BY2PR12MB0148;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BY2PR12MB0148; X-Forefront-PRVS: 0448A97BF2 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(376002)(346002)(39860400002)(199003)(189002)(377454003)(24454002)(43544003)(6246003)(106356001)(65826007)(105586002)(6486002)(7736002)(81156014)(65956001)(66066001)(6506006)(5660300001)(54906003)(16526017)(316002)(305945005)(229853002)(58126008)(8936002)(33646002)(31686004)(81166006)(36756003)(53546010)(6916009)(2950100002)(6306002)(6512007)(64126003)(97736004)(50466002)(8676002)(47776003)(966005)(2906002)(53936002)(6666003)(83506001)(65806001)(86362001)(50986999)(23676002)(68736007)(230700001)(3846002)(101416001)(31696002)(478600001)(4326008)(25786009)(54356999)(189998001)(76176999)(6116002)(6606295002);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR12MB0148;H:Brijeshs-MacBook-Pro.local;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTJQUjEyTUIwMTQ4OzIzOlJXQVNOMlpvbW9NQlFvMkxrdGRUMVdlM1ov?= =?utf-8?B?QmN1dUtYNXRUcjFhVEtmSzBua3dvVlRvQXYrUlRIV0xqZjk1TktFRjBSZlc1?= =?utf-8?B?M285UlBvY0hlcjlZejQ2VWtrTGR5WWtrcFcyVTJTYys3NElJNm5nYlBaa3RU?= =?utf-8?B?VTJjTjJHaTdubmJua09oU1VpTTRvdTl6QlhUdVBndHV5SFIzdVUxUmdFRU5o?= =?utf-8?B?UGluZ3NROTFJaVZiYjREaVd3Nk9vL0FOcTRKUWJDcjdwNUVHWEhUa2ExbFl4?= =?utf-8?B?ZzUwZUl1bWNVNm80VzZ0ZGVva05FVFp4b1E2b0lTQTltNUdmaVJibi9tQmxX?= =?utf-8?B?aG1leHFZL1RURGdXek53OTJxb2oxVjBmWWpuMUdIQ2NQcERoZmpiZEZobkdp?= =?utf-8?B?OXd2bDFnakJOQkFtMHpCbU1SMkZZd1cwWTZmTFFWNlBDUGpDUDRRZ25aM2JS?= =?utf-8?B?Wi8zV3BrMEdOOUhxRjFiaGZUQjVGRUpqSmFDYUV1QlNidjVCWkwzWVp1bStm?= =?utf-8?B?YkhGYmVKTVpFUVhtejAwa0pOWVcwbVJpOVNJbTNqdnFtMGhWY2FNY0RERTVa?= =?utf-8?B?alliR3hFMFRYSDYvbTNseHV5bEhJSEVYWk5ocDg5QStiSmZMOTljY2RKRHpO?= =?utf-8?B?a1Rtb2ZzOWVldjE5b1g4N0JFTVRqL0V2RHMwRTdabWJ3Qkp1Ykl1eCtnL0w2?= =?utf-8?B?b1JpcXBXdkY4UkJ3dHVSYVd5SVdsWXhxRkpCcTdWVFhPQklUVDR2cTlGK3kv?= =?utf-8?B?SklYcmxsck1ZNHVNT245di9SVlk3dU5SSjNMYmNEamxJdHJzbFdTc3VHL0VU?= =?utf-8?B?WGFwcHZMam1yaWZpNnpXd0tseXJDQ2E1cEdvVU5WNGVoQkc4NWhMWmFjVE5p?= =?utf-8?B?TDh4MEl0MlJzeS9ta0tESUFiOXZUN3pJc2JxaDh6ODlRZDJwYkVLYnVjemJN?= =?utf-8?B?UVVaSjU3R2JKT3ZqYzZxQzFxWEdvRVlxMTdTOGVLMmJ1REVVNnJza09UWmsr?= =?utf-8?B?azE5OFptMTZ6VE8wQTVwUmk4eHBMdU04azFWdXNGbTQ5cGxiUmZxOUxPUWdy?= =?utf-8?B?c3QvQW0vTjQvYlZoVjhiTXBObHh0d0xKRzZoM0xHdk5WZC9FNUJQbDNwR3Iv?= =?utf-8?B?WU0yZkVGNzNINDZIbFZtZkxuZVQxeFphZlByTFdJTTErUlZRczJuTkJvQzJ6?= =?utf-8?B?L3dJL3BGdTAzN3U0WGVKdWhVcHYzRzBMQkVhZUtiYkNoNGVWWkJWRys3bjg2?= =?utf-8?B?MHhKU3o2VktibjBjWkhsU0JFVm84YjZuNTY1RlFkY21ob244TUpIa01FU3pa?= =?utf-8?B?bGg4cGx4TmRZWUNOcncrKzd4SVl2RFU3b1BjNWRpNEpmcjlLQlhLQ0E3QXFm?= =?utf-8?B?WklQUmZwOENKSXdyYU9EamZMNFBhVWxod0hLVGw5MGZJWUtLSWdWNFZiUUhV?= =?utf-8?B?L3VNa2prdkN5OHFmWm1xTU9HaWNJdnBFd2l6ZXJXeXozQnpUbGIzdTJGQUlB?= =?utf-8?B?T0h2Mi9DZ1dOTXBQdWFYaDZSWXdjeVNHNENvTkNoVnV6VUZJbnlXRWZlVVNK?= =?utf-8?B?cG0yczFvYjdXcitjTFNhbW16blJSMjdvMFdsY0t1WUxNZXQzbkxHVG5NWGVJ?= =?utf-8?B?QWllV2lMYnNsbU4zbDVsMGo5TXdzTERWak52VlVBcEREU3cvUnRRQVlmQ3Rm?= =?utf-8?B?bTk2OE1tendrYTJDa3JQeHM3TysxN1hvbTEwQmZWb0Q5YlV5SWI0YmRJZG96?= =?utf-8?B?eURqSmlWS2JUb2dhbjRmVkpxNXZMd1dPL05RZDEydmNvN2R2YXNzMDUwSVNK?= =?utf-8?B?YzFVSFRkdmhWQ2FDam1HQVVHK0luU0k1dkRwNUJnTzBzdmFRcHJ3R3lPZ2lq?= =?utf-8?B?OVpYRHJQdkZIai9BRUpwYUE3NkZsYmJQQzNOeENRQjlHQjg4NWR3N3hGMGxu?= =?utf-8?Q?8UOanxzpJyPQhsCNupLre+3x4HDJFk=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0148;6:HZbHxA36BbC7knhXw0Hpgu+r1k4udB7X+a1+5K5uMrJ/qhih7bR+nLuOgz+cB+52OYKQltChzIm7dvkSmAdWopG2Y/YzNIFiH2m+lUvxTLAlpAroB8aMrNRVh+SAsqM9Ty3K6UNYX+fcH7n0x62h62+fOVh1zp+0yQZ4wFfQFfKo25qNTGELiE3JuHQE5c9yo1F8cnKrz5NcY6Xszog6+yq2Z+U4rBPu++MvV+1ejZc0EUnj6SSWajWvyy8YlttV8y3m2OCLuAdfMBTlsTSDyWpUstb0iCKXeQXjC3XM1MZuovNPdTDX4jWD55vjvlplVs1TSFNvRIFFvQ/O9nzU3A==;5:EfHiOrHQ/fO0cpnlWzkpMJu2gfy4EvpJRlOv5q/eb8du9Gqer4L7CXNFIjdJjFpjNCnsfjc0PSa0IRcU9YJSatR4MW1MlNmvirxAujTsm3pMV7rYk0MVdlgg6PSM17yJRkBNRvrJfbSJuh+SjpMZQw==;24:bE+fZClIjKBc5wxCLcuSaPWuCPV0aXKK36rP0tpRPl6Z6w1ye++bZlabb0x/S+N85QFotD852VB/fPZm4ce1sSKE2OBH+dxz9ykYQDHzHOU=;7:zcr/EyfDM6WnPOTGs3Ciw/KbPo+HjoED92Yw+1HtWMZwMEkdd4FQ5946Tktt1Aput4lMYsGXFPxVsyodyrMfggpJoqywli4RMIyAZP7ujxx+IMc15ZhX81WOUb9rjYf+vYZSb5c4tH4Jp4VfcnYNoMvd1SWlMTTraR/tyVu1jy6K1IiOIe/jxAD79gcGqhpzlyYEWkNQ6407MNZlvOby2CPsSTOkciCPE9g0KhvKgjk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0148;20:vg6pCzP6SvYUOEUH9H1sMLFq3VUYM5ml83nrzh/Xarm1sUSBrAMPyqXKdyLrSgKyZyjqENVgD169VOWpTDfgjO+tEKtWssr2b0X128koAD1tqA9y6rUxSnoAiS3F5NC1JT+R4o41nPVLFAvjkY7SLzGOpg4dFNDGvTZHeXefz3S4pKqFFpWN2a3oO8zSr6R+gNZw5Q5VExJSoLqWdyQR39fTxbGaJ8tg9AJGN74dhWHWiK8CvLOPynTGC+gBPmEE X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2017 11:32:22.3778 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR12MB0148 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/1/17 5:02 PM, Borislav Petkov wrote: > On Sun, Oct 01, 2017 at 02:45:09PM -0500, Brijesh Singh wrote: >>> So I want to be able to disable SEV and the whole code that comes with >>> it in the *host*. >> We can add a new variable 'sme_only'. By default this variable should be set >> to false. When mem_encrypt=sme is passed then set it to true and >> based on sme_only state early_detect_mem_encrypt() can clear X86_FEATURE_SEV >> flag. > Why would you need yet another variable? We have sev_enabled already?!? Because sev_enabled will always be 'false' when we are booting on bare metal. Whereas when we are running under hypervisor then this variable will be true for the SEV guest, please see [1]. Both sev_active() and sme_active() make use of this variable hence we will not be able to set the sev_enabled variable on bare metal. Basically none of the SEV cases will be executed on bare metal -- only thing which we need to take care of is clearing the X86_FEATURE_SEV flag so that hypervisor will never launch SEV guest when mem_encrypt=sme option is provided. [1] https://marc.info/?l=linux-kernel&m=150672050612826&w=2 >