From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BABAC433E2 for ; Mon, 7 Sep 2020 11:34:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 335812166E for ; Mon, 7 Sep 2020 11:34:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729037AbgIGLem (ORCPT ); Mon, 7 Sep 2020 07:34:42 -0400 Received: from foss.arm.com ([217.140.110.172]:33344 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729006AbgIGL37 (ORCPT ); Mon, 7 Sep 2020 07:29:59 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6C3CF12FC; Mon, 7 Sep 2020 04:29:58 -0700 (PDT) Received: from [10.37.12.62] (unknown [10.37.12.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 316CF3F66E; Mon, 7 Sep 2020 04:29:56 -0700 (PDT) Subject: Re: [PATCH] PM: : fix @em_pd kernel-doc warning To: Randy Dunlap , LKML , Linux PM list , Rafael Wysocki , Greg Kroah-Hartman References: From: Lukasz Luba Message-ID: <6de9dd19-3bbc-41a7-b36d-9f085eb2e548@arm.com> Date: Mon, 7 Sep 2020 12:29:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Randy, On 9/7/20 4:42 AM, Randy Dunlap wrote: > From: Randy Dunlap > > Fix kernel-doc warning in : > > ../include/linux/device.h:613: warning: Function parameter or member 'em_pd' not described in 'device' > > Fixes: 1bc138c62295 ("PM / EM: add support for other devices than CPUs in Energy Model") > Signed-off-by: Randy Dunlap > Cc: Lukasz Luba > Cc: Rafael J. Wysocki > --- > include/linux/device.h | 1 + > 1 file changed, 1 insertion(+) > > --- lnx-59-rc4.orig/include/linux/device.h > +++ lnx-59-rc4/include/linux/device.h > @@ -454,6 +454,7 @@ struct dev_links_info { > * @pm_domain: Provide callbacks that are executed during system suspend, > * hibernation, system resume and during runtime PM transitions > * along with subsystem-level and driver-level callbacks. > + * @em_pd: device's energy model performance domain > * @pins: For device pin management. > * See Documentation/driver-api/pinctl.rst for details. > * @msi_list: Hosts MSI descriptors > Good catch. Thank you for the patch. Reviewed-by: Lukasz Luba Regards, Lukasz Luba