From: John Garry <john.garry@huawei.com>
To: Dmitry Safonov <0x7f454c46@gmail.com>, Will Deacon <will@kernel.org>
Cc: Joerg Roedel <joro@8bytes.org>, <robin.murphy@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
<kernel-team@android.com>, <xiyou.wangcong@gmail.com>,
<linuxarm@huawei.com>, <iommu@lists.linux-foundation.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH v3 0/4] iommu/iova: Solve longterm IOVA issue
Date: Thu, 3 Dec 2020 14:54:27 +0000 [thread overview]
Message-ID: <6e09d847-fb7f-1ec1-02bf-f0c8b315845f@huawei.com> (raw)
In-Reply-To: <CAJwJo6YmF+tW2_it2BLCP6fLBrUR6kfx7jG0hsNy6uYG203Jfw@mail.gmail.com>
On 03/12/2020 06:04, Dmitry Safonov wrote:
> On Tue, 1 Dec 2020 at 21:50, Will Deacon<will@kernel.org> wrote:
>> On Tue, 17 Nov 2020 18:25:30 +0800, John Garry wrote:
>>> This series contains a patch to solve the longterm IOVA issue which
>>> leizhen originally tried to address at [0].
>>>
>>> A sieved kernel log is at the following, showing periodic dumps of IOVA
>>> sizes, per CPU and per depot bin, per IOVA size granule:
>>> https://raw.githubusercontent.com/hisilicon/kernel-dev/topic-iommu-5.10-iova-debug-v3/aging_test
>>>
>>> [...]
>> Applied the final patch to arm64 (for-next/iommu/iova), thanks!
>>
>> [4/4] iommu: avoid taking iova_rbtree_lock twice
>> https://git.kernel.org/arm64/c/3a651b3a27a1
> Glad it made in next, 2 years ago I couldn't convince iommu maintainer
> it's worth it (but with a different justification):
> https://lore.kernel.org/linux-iommu/20180621180823.805-3-dima@arista.com/
Hi Dmitry,
I was unaware of your series, and it’s unfortunate that your
optimization never made it. However I was having a quick look there,
and, in case you did not notice, that the code which you were proposing
changing in patch #1 for intel-iommu.c was removed in e70b081c6f37
("iommu/vt-d: Remove IOVA handling code from the non-dma_ops path").
BTW, split_and_remove_iova() has no in-tree users anymore, so I can send
a patch to delete if nobody else wants to.
BTW2, there's some more patches in my series which could use a review if
you're feeling very helpful :)
Cheers,
John
next prev parent reply other threads:[~2020-12-03 14:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 10:25 [RESEND PATCH v3 0/4] iommu/iova: Solve longterm IOVA issue John Garry
2020-11-17 10:25 ` [RESEND PATCH v3 1/4] iommu/iova: Add free_all_cpu_cached_iovas() John Garry
2020-12-09 8:58 ` Leizhen (ThunderTown)
2020-12-09 12:41 ` John Garry
2020-11-17 10:25 ` [RESEND PATCH v3 2/4] iommu/iova: Avoid double-negatives in magazine helpers John Garry
2020-12-09 9:03 ` Leizhen (ThunderTown)
2020-12-09 11:39 ` John Garry
2020-12-09 12:31 ` Leizhen (ThunderTown)
2020-11-17 10:25 ` [RESEND PATCH v3 3/4] iommu/iova: Flush CPU rcache for when a depot fills John Garry
2020-12-09 9:13 ` Leizhen (ThunderTown)
2020-12-09 11:22 ` John Garry
2020-12-09 12:11 ` Leizhen (ThunderTown)
2020-11-17 10:25 ` [RESEND PATCH v3 4/4] iommu: avoid taking iova_rbtree_lock twice John Garry
2020-12-01 15:35 ` [RESEND PATCH v3 0/4] iommu/iova: Solve longterm IOVA issue John Garry
2020-12-01 21:02 ` Will Deacon
2020-12-02 15:20 ` John Garry
2020-12-01 21:45 ` Will Deacon
2020-12-03 6:04 ` Dmitry Safonov
2020-12-03 14:54 ` John Garry [this message]
2021-01-15 11:32 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e09d847-fb7f-1ec1-02bf-f0c8b315845f@huawei.com \
--to=john.garry@huawei.com \
--cc=0x7f454c46@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).