From: Philipp Zabel <p.zabel@pengutronix.de>
To: "Álvaro Fernández Rojas" <noltari@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>
Cc: robh+dt@kernel.org, tsbogend@alpha.franken.de,
Jonas Gorski <jonas.gorski@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH 3/7] reset: add BCM6345 reset controller driver
Date: Wed, 10 Jun 2020 09:28:58 +0200 [thread overview]
Message-ID: <6e387142f0f07491f8b2b66c970e7ead8e94de7b.camel@pengutronix.de> (raw)
In-Reply-To: <41A1CC01-BFA0-48A1-A2EE-7917B3A1323A@gmail.com>
Hi Álvaro,
On Wed, 2020-06-10 at 08:08 +0200, Álvaro Fernández Rojas wrote:
> Hi Florian,
>
> > El 9 jun 2020, a las 22:17, Florian Fainelli <f.fainelli@gmail.com> escribió:
> >
> >
> >
> > On 6/9/2020 9:41 AM, Álvaro Fernández Rojas wrote:
> > > > > > If you can do without this, with I think this driver could be made to
> > > > > > use reset-simple.
> > > > >
> > > > > Yes, but only if I can add reset support with a configurable sleep range to reset-simple. Is this possible?
> > > >
> > > > I should have mentioned, support for this is on the reset/next branch:
> > > >
> > > > git://git.pengutronix.de/pza/linux.git reset/next
> > >
> > > Yes, but reset_us was only added to reset_simple_data, so there’s no way to fill that value from reset_simple_devdata or device tree, right?
> >
> > Not that I can see, but you could certainly extend it here:
> >
> > if (devdata) {
> > reg_offset = devdata->reg_offset;
> > if (devdata->nr_resets)
> > data->rcdev.nr_resets = devdata->nr_resets;
> > data->active_low = devdata->active_low;
> > data->status_active_low = devdata->status_active_low;
> > }
>
> Yes, I would extend it there too,
You are right, reset_us is missing from reset_simple_devdata.
> but I was just saying that it’s a bit strange that it was only added
> to reset_simple_data without any way to fill the value.
The patch was added for the benefit of drivers that register their own
reset controller using reset_simple_data/ops, like sunxi or socfpga.
This might be considered an oversight, but until now there was no user
inside reset-simple.c.
regards
Philipp
next prev parent reply other threads:[~2020-06-10 7:29 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 13:42 [PATCH 0/7] bmips: add bcm6345 reset controller support Álvaro Fernández Rojas
2020-06-09 13:42 ` [PATCH 1/7] mips: bmips: select ARCH_HAS_RESET_CONTROLLER Álvaro Fernández Rojas
2020-06-09 13:42 ` [PATCH 2/7] dt-bindings: reset: add BCM6345 reset controller bindings Álvaro Fernández Rojas
2020-06-09 13:42 ` [PATCH 3/7] reset: add BCM6345 reset controller driver Álvaro Fernández Rojas
2020-06-09 15:06 ` Philipp Zabel
2020-06-09 15:14 ` Álvaro Fernández Rojas
2020-06-09 16:32 ` Philipp Zabel
2020-06-09 16:41 ` Álvaro Fernández Rojas
2020-06-09 20:17 ` Florian Fainelli
2020-06-10 6:08 ` Álvaro Fernández Rojas
2020-06-10 7:28 ` Philipp Zabel [this message]
2020-06-09 13:42 ` [PATCH 4/7] mips: bmips: dts: add BCM6328 reset controller support Álvaro Fernández Rojas
2020-06-09 13:42 ` [PATCH 5/7] mips: bmips: dts: add BCM6358 " Álvaro Fernández Rojas
2020-06-09 13:42 ` [PATCH 6/7] mips: bmips: dts: add BCM6362 " Álvaro Fernández Rojas
2020-06-09 13:42 ` [PATCH 7/7] mips: bmips: dts: add BCM6368 " Álvaro Fernández Rojas
2020-06-09 16:02 ` [PATCH v2 0/7] bmips: add bcm6345 " Álvaro Fernández Rojas
2020-06-09 16:02 ` [PATCH v2 1/7] mips: bmips: select ARCH_HAS_RESET_CONTROLLER Álvaro Fernández Rojas
2020-06-10 1:03 ` Florian Fainelli
2020-06-09 16:02 ` [PATCH v2 2/7] dt-bindings: reset: add BCM6345 reset controller bindings Álvaro Fernández Rojas
2020-06-10 1:11 ` Florian Fainelli
2020-06-09 16:02 ` [PATCH v2 3/7] drivers: reset: simple: add BCM6345 reset support Álvaro Fernández Rojas
2020-06-10 1:05 ` Florian Fainelli
2020-06-10 6:06 ` Álvaro Fernández Rojas
2020-06-09 16:02 ` [PATCH v2 4/7] mips: bmips: dts: add BCM6328 reset controller support Álvaro Fernández Rojas
2020-06-10 1:08 ` Florian Fainelli
2020-06-10 6:05 ` Álvaro Fernández Rojas
2020-06-09 16:02 ` [PATCH v2 5/7] mips: bmips: dts: add BCM6358 " Álvaro Fernández Rojas
2020-06-10 1:08 ` Florian Fainelli
2020-06-09 16:02 ` [PATCH v2 6/7] mips: bmips: dts: add BCM6362 " Álvaro Fernández Rojas
2020-06-10 1:09 ` Florian Fainelli
2020-06-09 16:02 ` [PATCH v2 7/7] mips: bmips: dts: add BCM6368 " Álvaro Fernández Rojas
2020-06-10 1:09 ` Florian Fainelli
2020-06-10 17:28 ` [PATCH v3 0/9] bmips: add bcm6345 " Álvaro Fernández Rojas
2020-06-10 17:28 ` [PATCH v3 1/9] mips: bmips: select ARCH_HAS_RESET_CONTROLLER Álvaro Fernández Rojas
2020-06-10 17:28 ` [PATCH v3 2/9] dt-bindings: reset: add BCM6345 reset controller bindings Álvaro Fernández Rojas
2020-06-12 21:57 ` Rob Herring
2020-06-12 22:37 ` Florian Fainelli
2020-06-10 17:28 ` [PATCH v3 3/9] reset: add BCM6345 reset controller driver Álvaro Fernández Rojas
2020-06-10 17:28 ` [PATCH v3 4/9] mips: bmips: dts: add BCM6328 reset controller support Álvaro Fernández Rojas
2020-06-10 17:28 ` [PATCH v3 5/9] mips: bmips: dts: add BCM6358 " Álvaro Fernández Rojas
2020-06-10 17:28 ` [PATCH v3 6/9] mips: bmips: dts: add BCM6362 " Álvaro Fernández Rojas
2020-06-10 17:28 ` [PATCH v3 7/9] mips: bmips: dts: add BCM6368 " Álvaro Fernández Rojas
2020-06-10 17:28 ` [PATCH v3 8/9] mips: bmips: dts: add BCM63268 " Álvaro Fernández Rojas
2020-06-10 17:28 ` [PATCH v3 9/9] mips: bmips: add BCM6318 reset controller definitions Álvaro Fernández Rojas
2020-06-13 8:38 ` [PATCH v4 0/9] bmips: add bcm6345 reset controller support Álvaro Fernández Rojas
2020-06-13 8:38 ` [PATCH v4 1/9] mips: bmips: select ARCH_HAS_RESET_CONTROLLER Álvaro Fernández Rojas
2020-06-13 8:38 ` [PATCH v4 2/9] dt-bindings: reset: add BCM6345 reset controller bindings Álvaro Fernández Rojas
2020-06-13 8:38 ` [PATCH v4 3/9] reset: add BCM6345 reset controller driver Álvaro Fernández Rojas
2020-06-14 3:33 ` kernel test robot
2020-06-14 4:52 ` Florian Fainelli
2020-06-13 8:38 ` [PATCH v4 4/9] mips: bmips: dts: add BCM6328 reset controller support Álvaro Fernández Rojas
2020-06-13 8:38 ` [PATCH v4 5/9] mips: bmips: dts: add BCM6358 " Álvaro Fernández Rojas
2020-06-13 8:38 ` [PATCH v4 6/9] mips: bmips: dts: add BCM6362 " Álvaro Fernández Rojas
2020-06-13 8:38 ` [PATCH v4 7/9] mips: bmips: dts: add BCM6368 " Álvaro Fernández Rojas
2020-06-13 8:38 ` [PATCH v4 8/9] mips: bmips: dts: add BCM63268 " Álvaro Fernández Rojas
2020-06-14 4:50 ` Florian Fainelli
2020-06-13 8:38 ` [PATCH v4 9/9] mips: bmips: add BCM6318 reset controller definitions Álvaro Fernández Rojas
2020-06-14 4:51 ` Florian Fainelli
2020-06-14 8:58 ` [PATCH v5 0/9] bmips: add bcm6345 reset controller support Álvaro Fernández Rojas
2020-06-14 8:58 ` [PATCH v5 1/9] mips: bmips: select ARCH_HAS_RESET_CONTROLLER Álvaro Fernández Rojas
2020-06-14 8:58 ` [PATCH v5 2/9] dt-bindings: reset: add BCM6345 reset controller bindings Álvaro Fernández Rojas
2020-06-14 8:58 ` [PATCH v5 3/9] reset: add BCM6345 reset controller driver Álvaro Fernández Rojas
2020-06-14 8:58 ` [PATCH v5 4/9] mips: bmips: dts: add BCM6328 reset controller support Álvaro Fernández Rojas
2020-06-14 8:58 ` [PATCH v5 5/9] mips: bmips: dts: add BCM6358 " Álvaro Fernández Rojas
2020-06-14 8:58 ` [PATCH v5 6/9] mips: bmips: dts: add BCM6362 " Álvaro Fernández Rojas
2020-06-14 8:58 ` [PATCH v5 7/9] mips: bmips: dts: add BCM6368 " Álvaro Fernández Rojas
2020-06-14 8:58 ` [PATCH v5 8/9] mips: bmips: dts: add BCM63268 " Álvaro Fernández Rojas
2020-06-14 8:58 ` [PATCH v5 9/9] mips: bmips: add BCM6318 reset controller definitions Álvaro Fernández Rojas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e387142f0f07491f8b2b66c970e7ead8e94de7b.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jonas.gorski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=noltari@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).