From: Yang Yingliang <yangyingliang@huawei.com>
To: Marc Zyngier <maz@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <tglx@linutronix.de>
Subject: Re: [PATCH -next] irqchip/mbigen: fix compile warning when CONFIG_ACPI is disabled
Date: Wed, 19 May 2021 17:00:51 +0800 [thread overview]
Message-ID: <6e4ff8c0-a297-e341-f430-9016920b3f48@huawei.com> (raw)
In-Reply-To: <c9e2dee2a7bb11d3327bbe55f4f7cf05@kernel.org>
On 2021/5/19 15:49, Marc Zyngier wrote:
> On 2021-05-19 06:04, Yang Yingliang wrote:
>> Fix the following compile warning:
>>
>> drivers/irqchip/irq-mbigen.c:372:36: warning: ‘mbigen_acpi_match’
>> defined but not used [-Wunused-const-variable=]
>> static const struct acpi_device_id mbigen_acpi_match[] = {
>>
>> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
>> ---
>> drivers/irqchip/irq-mbigen.c | 12 ++++++------
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c
>> index 2cb45c6b8501..f565317a3da3 100644
>> --- a/drivers/irqchip/irq-mbigen.c
>> +++ b/drivers/irqchip/irq-mbigen.c
>> @@ -273,6 +273,12 @@ static int mbigen_of_create_domain(struct
>> platform_device *pdev,
>> }
>>
>> #ifdef CONFIG_ACPI
>> +static const struct acpi_device_id mbigen_acpi_match[] = {
>> + { "HISI0152", 0 },
>> + {}
>> +};
>> +MODULE_DEVICE_TABLE(acpi, mbigen_acpi_match);
>> +
>> static int mbigen_acpi_create_domain(struct platform_device *pdev,
>> struct mbigen_device *mgn_chip)
>> {
>> @@ -369,12 +375,6 @@ static const struct of_device_id
>> mbigen_of_match[] = {
>> };
>> MODULE_DEVICE_TABLE(of, mbigen_of_match);
>>
>> -static const struct acpi_device_id mbigen_acpi_match[] = {
>> - { "HISI0152", 0 },
>> - {}
>> -};
>> -MODULE_DEVICE_TABLE(acpi, mbigen_acpi_match);
>> -
>> static struct platform_driver mbigen_platform_driver = {
>> .driver = {
>> .name = "Hisilicon MBIGEN-V2",
>
> Is it actually a thing to have mbigen without ACPI? As far as I can
> tell, all the mbigen-equipped machines in existence use ACPI.
We also use mbigen on embedded board that uses device tree,
and mbigen driver already support device tree mode.
Thanks,
Yang
>
> Thanks,
>
> M.
next prev parent reply other threads:[~2021-05-19 9:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 5:04 [PATCH -next] irqchip/mbigen: fix compile warning when CONFIG_ACPI is disabled Yang Yingliang
2021-05-19 7:49 ` Marc Zyngier
2021-05-19 9:00 ` Yang Yingliang [this message]
2021-06-06 13:07 ` [irqchip: irq/irqchip-next] irqchip/mbigen: Fix " irqchip-bot for Yang Yingliang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e4ff8c0-a297-e341-f430-9016920b3f48@huawei.com \
--to=yangyingliang@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).