From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7851C0044C for ; Wed, 7 Nov 2018 17:18:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9CD012081D for ; Wed, 7 Nov 2018 17:18:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CD012081D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=virtuozzo.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731510AbeKHCtg (ORCPT ); Wed, 7 Nov 2018 21:49:36 -0500 Received: from relay.sw.ru ([185.231.240.75]:37392 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731485AbeKHCtg (ORCPT ); Wed, 7 Nov 2018 21:49:36 -0500 Received: from [172.16.24.21] by relay.sw.ru with esmtp (Exim 4.90_1) (envelope-from ) id 1gKRT4-0003iq-7z; Wed, 07 Nov 2018 20:18:14 +0300 Subject: Re: [PATCH 1/7] ext4: lost brelse in __ext4_read_dirblock() To: "Theodore Y. Ts'o" , linux-ext4@vger.kernel.org, Andreas Dilger , linux-kernel@vger.kernel.org References: <60f19df8-1e65-99a0-cb6b-696d1b530fd4@virtuozzo.com> <20181107152549.GB9919@thunk.org> From: Vasily Averin Message-ID: <6e5c9e17-5916-7296-35a0-cc0600a79f27@virtuozzo.com> Date: Wed, 7 Nov 2018 20:18:13 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181107152549.GB9919@thunk.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I was wrong here, but brelse is lost in next error in this function. I'll resend new patch. On 11/7/18 6:25 PM, Theodore Y. Ts'o wrote: > On Wed, Oct 31, 2018 at 10:12:18PM +0300, Vasily Averin wrote: >> Fixes dc6982ff4db1 ("ext4: refactor code to read directory blocks ...") # 3.9 >> >> Signed-off-by: Vasily Averin >> --- >> fs/ext4/namei.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c >> index d388cce72db2..1a21e59ede72 100644 >> --- a/fs/ext4/namei.c >> +++ b/fs/ext4/namei.c >> @@ -111,6 +111,7 @@ static struct buffer_head *__ext4_read_dirblock(struct inode *inode, >> if (!bh) { >> ext4_error_inode(inode, func, line, block, >> "Directory hole found"); >> + brelse(bh); >> return ERR_PTR(-EFSCORRUPTED); >> } >> dirent = (struct ext4_dir_entry *) bh->b_data; > > Inside the conditional, bh == NULL, so the brelse isn't needed. > > Cheers, > > - Ted >