From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753314AbcGTKhn (ORCPT ); Wed, 20 Jul 2016 06:37:43 -0400 Received: from lb1-smtp-cloud6.xs4all.net ([194.109.24.24]:44348 "EHLO lb1-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751996AbcGTKhi (ORCPT ); Wed, 20 Jul 2016 06:37:38 -0400 Subject: Re: [PATCH 0/6] radio: Utilize the module_isa_driver macro To: William Breathitt Gray , mchehab@osg.samsung.com References: Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org From: Hans Verkuil Message-ID: <6e689553-b3bc-c5d1-1246-ff109d2bba17@xs4all.nl> Date: Wed, 20 Jul 2016 12:37:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/18/2016 04:45 PM, William Breathitt Gray wrote: > The module_isa_driver macro is a helper macro for ISA drivers which do > not do anything special in module init/exit. This patchset eliminates a > lot of ISA driver registration boilerplate code by utilizing > module_isa_driver, which replaces module_init and module_exit. > > William Breathitt Gray (6): > radio: terratec: Utilize the module_isa_driver macro > radio: rtrack2: Utilize the module_isa_driver macro > radio: trust: Utilize the module_isa_driver macro > radio: zoltrix: Utilize the module_isa_driver macro > radio: aztech: Utilize the module_isa_driver macro > radio: aimslab: Utilize the module_isa_driver macro Good idea, but it doesn't compile: module_isa_driver(terratec_driver.driver, 1); expands to: static int __init terratec_driver.driver_init(void) { return isa_register_driver(&(terratec_driver.driver), 1); } So now the function name contains a '.' and it won't compile. Regards, Hans