From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8489C433B4 for ; Tue, 18 May 2021 11:13:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A401661001 for ; Tue, 18 May 2021 11:13:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348753AbhERLOT (ORCPT ); Tue, 18 May 2021 07:14:19 -0400 Received: from mx2.suse.de ([195.135.220.15]:60494 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241330AbhERLOI (ORCPT ); Tue, 18 May 2021 07:14:08 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 01033AFE6; Tue, 18 May 2021 11:12:50 +0000 (UTC) Subject: Re: [PATCH v10 26/33] mm/writeback: Add folio_wait_writeback To: "Matthew Wilcox (Oracle)" , akpm@linux-foundation.org Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Jeff Layton References: <20210511214735.1836149-1-willy@infradead.org> <20210511214735.1836149-27-willy@infradead.org> From: Vlastimil Babka Message-ID: <6e998f49-f37e-c7ce-278e-e220a7212f10@suse.cz> Date: Tue, 18 May 2021 13:12:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210511214735.1836149-27-willy@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/11/21 11:47 PM, Matthew Wilcox (Oracle) wrote: > wait_on_page_writeback_killable() only has one caller, so convert it to > call folio_wait_writeback_killable(). For the wait_on_page_writeback() > callers, add a compatibility wrapper around folio_wait_writeback(). > > Turning PageWriteback() into folio_writeback() eliminates a call to > compound_head() which saves 8 bytes and 15 bytes in the two functions. > That is more than offset by adding the wait_on_page_writeback > compatibility wrapper for a net increase in text of 15 bytes. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig > Acked-by: Jeff Layton Acked-by: Vlastimil Babka