From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35479C49361 for ; Mon, 28 Jun 2021 12:10:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0EF8361C74 for ; Mon, 28 Jun 2021 12:10:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232897AbhF1MNJ (ORCPT ); Mon, 28 Jun 2021 08:13:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232802AbhF1MNH (ORCPT ); Mon, 28 Jun 2021 08:13:07 -0400 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C795C061574 for ; Mon, 28 Jun 2021 05:10:42 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id l18-20020a1ced120000b029014c1adff1edso13581751wmh.4 for ; Mon, 28 Jun 2021 05:10:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/s5ntRR1JmxnVmTebmtMvo/S0ha2iJsjhTLPq9iWUNo=; b=r8DcmgKnJzDsSe9H9XdHRMx+qFTw3ab7ZUGEi94m8rfq2F5rg2c3b66zKeWc47rsv+ JXd54tjxiqLkS9ohZddHT2jh4w8bexyyZygC3N5k/EWMhLA3bafolhAO3nook56HshOO Yi1knHs/uDdKJCblnujaNy+A2FKiAU2HOp4u8NJyR73sYUdOkgof9wm4kI52ASzszIMq BgRNtuxIqpkS/WQ2/+LImWHrNB1AYq0nmfPmUZZSi2GH9XUdpJcoEEtzy8YIlZn1uZ3V 22oNnxICMAA/HAbsCgfU7gVpvob6AebRLP5qib+NOaraQ3V8o5fgcmrzPGGj8ThS2da4 4X3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/s5ntRR1JmxnVmTebmtMvo/S0ha2iJsjhTLPq9iWUNo=; b=rr/jGi4ZHlusKyu9b8GHzBV9xWA/rgEtCcUos1MTU8XvfQUs+Gr4xbywdn3wet15NN fMYarulP4Ge5C7JmiO7y+fUGaJkCc5io90QtmVuDEiHVzq9FT6+q8FxkBF1C9wbuzqC/ ffJWqgYL4Uzd5mdHEYiny9krWD1s91QvgTSTl1NJUJg/tnW0MCX1KzLdbzGOsVlj2de8 f/xNTBZRv2QGzJm1ITiCz+KDiWnqXWyKsOnS0j9YnQ1j+YIer8oQz0k3Yu+oOIjijojP mUGzHraHZF33Wapdtq8/9w2TWY+eNs6m1ycGIRoFLZ9anor5Ak3pi36S1/IuQa+HLr4v 4rVg== X-Gm-Message-State: AOAM531DrDkS8CFdJSDNAFvNOmNr20poRsSjrNJVvjS/hjNi6Tm0ENx+ im28wYtX33hREfP/S1cBK/g= X-Google-Smtp-Source: ABdhPJw0b+zEVGJoy+JpR4p2RvtMfiKkQ7V22N6GI37OQ3+H+aRCKqKL/+Qe9aHWKx8qF5tmN77JFg== X-Received: by 2002:a05:600c:2cb5:: with SMTP id h21mr1646938wmc.91.1624882240885; Mon, 28 Jun 2021 05:10:40 -0700 (PDT) Received: from [10.8.0.150] ([195.53.121.100]) by smtp.gmail.com with ESMTPSA id c133sm19076433wmf.0.2021.06.28.05.10.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Jun 2021 05:10:40 -0700 (PDT) Subject: Re: [RFC] strcpys(): New function for copying strings safely From: "Alejandro Colomar (man-pages)" To: David Laight , glibc Cc: "tech@openbsd.org" , Christoph Hellwig , "linux-kernel@vger.kernel.org" , drepper@gmail.com References: <755875ec-baae-6cab-52a8-3c9530db1ce6@gmail.com> <38428d5e-ead2-bf18-e198-cecd4caeb3e7@gmail.com> <52e57bd5-0d04-4b4f-978a-8c1dbc08115c@gmail.com> Message-ID: <6ea2efaf-7898-9723-54e7-2cd59702f854@gmail.com> Date: Mon, 28 Jun 2021 14:10:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/28/21 2:00 PM, Alejandro Colomar (man-pages) wrote: > l = strscat(n - l, dest + l, src2); Hmm, that's a bug; I wrote it too fast. Either l += strscpy(n - l, dest + l, src2); or l = strscat(n - l, dest, src2); should be used instead. -- Alejandro Colomar Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/ http://www.alejandro-colomar.es/