From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754454AbeALHv1 (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Fri, 12 Jan 2018 02:51:27 -0500
Received: from szxga04-in.huawei.com ([45.249.212.190]:4173 "EHLO huawei.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1753876AbeALHv0 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 12 Jan 2018 02:51:26 -0500
Subject: Re: [PATCH v4] perf tools: Add ARM Statistical Profiling Extensions
 (SPE) support
To: Adrian Hunter <adrian.hunter@intel.com>,
        Kim Phillips <kim.phillips@arm.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        "Mark Rutland" <mark.rutland@arm.com>,
        Will Deacon <will.deacon@arm.com>
CC: <robh@kernel.org>, Andi Kleen <ak@linux.intel.com>,
        <mathieu.poirier@linaro.org>, <pawel.moll@arm.com>,
        <suzuki.poulose@arm.com>, <marc.zyngier@arm.com>,
        <linux-kernel@vger.kernel.org>,
        <alexander.shishkin@linux.intel.com>, <peterz@infradead.org>,
        <mingo@redhat.com>, Jiri Olsa <jolsa@kernel.org>,
        <tglx@linutronix.de>, "Wang Nan" <wangnan0@huawei.com>,
        <linux-arm-kernel@lists.infradead.org>
References: <20171121173302.bead17a1178ed4583e68014e@arm.com>
 <0a07a10c-fc0c-3f97-ac01-59429aab0937@intel.com>
From: gengdongjiu <gengdongjiu@huawei.com>
Message-ID: <6ec89c5b-e978-bd2e-e350-df0c7c41ac33@huawei.com>
Date: Fri, 12 Jan 2018 15:51:00 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <0a07a10c-fc0c-3f97-ac01-59429aab0937@intel.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.142.68.147]
X-CFilter-Loop: Reflected
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

On 2018/1/11 22:17, Adrian Hunter wrote:
>>   (e.g., via 'perf inject --itrace'), are also not supported
>>
>> - technically both cs-etm and spe can be used simultaneously, however
>>   disabled for simplicity in this release
>>
>> Signed-off-by: Kim Phillips <kim.phillips@arm.com>
> For what is there now, it looks fine from the auxtrace point of view.  There
> are a couple of minor points below but nevertheless:
> 
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>

This patch is good to me.
Reviewed-by: gengdongjiu@huawei.com

> 
>> ---
>> v4: rebased onto acme's perf/core, whitespace fixes.