From: Liang Yang <liang.yang@amlogic.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
<linux-amlogic@lists.infradead.org>,
<linux-mtd@lists.infradead.org>, <richard@nod.at>,
<miquel.raynal@bootlin.com>
Cc: <linux-arm-kernel@lists.infradead.org>, <marek.vasut@gmail.com>,
<linux-kernel@vger.kernel.org>, <computersforpeace@gmail.com>,
<dwmw2@infradead.org>, <bbrezillon@kernel.org>,
<jianxin.pan@amlogic.com>
Subject: Re: [PATCH 3/4] mtd: rawnand: meson: use a void pointer for meson_nfc_dma_buffer_setup
Date: Mon, 15 Apr 2019 14:03:57 +0800 [thread overview]
Message-ID: <6ed284c1-ed34-9483-51a4-a79dfd0bd42c@amlogic.com> (raw)
In-Reply-To: <20190411220056.19109-4-martin.blumenstingl@googlemail.com>
On 2019/4/12 6:00, Martin Blumenstingl wrote:
> This simplifies the code because it gets rid of the casts to an
> u8-pointer when passing "info_buf" from struct meson_nfc_nand_chip.
> Also it gets rid of the cast of the u8 databuf pointer to a void
> pointer.
> The logic inside meson_nfc_dma_buffer_setup() doesn't care about the
> pointer types themselves because it only passes them to dma_map_single
> which accepts a void pointer.
>
> No functional changes.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> drivers/mtd/nand/raw/meson_nand.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
> index 9a6023638101..57cc4bd3f665 100644
> --- a/drivers/mtd/nand/raw/meson_nand.c
> +++ b/drivers/mtd/nand/raw/meson_nand.c
> @@ -470,15 +470,15 @@ static int meson_nfc_ecc_correct(struct nand_chip *nand, u32 *bitflips,
> return ret;
> }
>
> -static int meson_nfc_dma_buffer_setup(struct nand_chip *nand, u8 *databuf,
> - int datalen, u8 *infobuf, int infolen,
> +static int meson_nfc_dma_buffer_setup(struct nand_chip *nand, void *databuf,
> + int datalen, void *infobuf, int infolen,
> enum dma_data_direction dir)
Tested-by:Liang Yang <liang.yang@amlogic.com>
Acked-by: Liang Yang <liang.yang@amlogic.com>
> {
> struct meson_nfc *nfc = nand_get_controller_data(nand);
> u32 cmd;
> int ret = 0;
>
> - nfc->daddr = dma_map_single(nfc->dev, (void *)databuf, datalen, dir);
> + nfc->daddr = dma_map_single(nfc->dev, databuf, datalen, dir);
> ret = dma_mapping_error(nfc->dev, nfc->daddr);
> if (ret) {
> dev_err(nfc->dev, "DMA mapping error\n");
> @@ -645,7 +645,7 @@ static int meson_nfc_write_page_sub(struct nand_chip *nand,
> return ret;
>
> ret = meson_nfc_dma_buffer_setup(nand, meson_chip->data_buf,
> - data_len, (u8 *)meson_chip->info_buf,
> + data_len, meson_chip->info_buf,
> info_len, DMA_TO_DEVICE);
Tested-by:Liang Yang <liang.yang@amlogic.com>
Acked-by: Liang Yang <liang.yang@amlogic.com>
> if (ret)
> return ret;
> @@ -729,7 +729,7 @@ static int meson_nfc_read_page_sub(struct nand_chip *nand,
> return ret;
>
> ret = meson_nfc_dma_buffer_setup(nand, meson_chip->data_buf,
> - data_len, (u8 *)meson_chip->info_buf,
> + data_len, meson_chip->info_buf,
Tested-by:Liang Yang <liang.yang@amlogic.com>
Acked-by: Liang Yang <liang.yang@amlogic.com>
> info_len, DMA_FROM_DEVICE);
> if (ret)
> return ret;
>
next prev parent reply other threads:[~2019-04-15 6:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 22:00 [PATCH 0/4] meson-nand: small code improvements Martin Blumenstingl
2019-04-11 22:00 ` [PATCH 1/4] mtd: rawnand: meson: use struct_size macro Martin Blumenstingl
2019-04-15 6:01 ` Liang Yang
2019-04-11 22:00 ` [PATCH 2/4] mtd: rawnand: meson: use of_property_count_elems_of_size helper Martin Blumenstingl
2019-04-15 6:02 ` Liang Yang
2019-04-11 22:00 ` [PATCH 3/4] mtd: rawnand: meson: use a void pointer for meson_nfc_dma_buffer_setup Martin Blumenstingl
2019-04-15 6:03 ` Liang Yang [this message]
2019-04-11 22:00 ` [PATCH 4/4] mtd: rawnand: meson: only initialize the RB completion once Martin Blumenstingl
2019-04-15 6:04 ` Liang Yang
2019-04-18 19:44 ` Martin Blumenstingl
2019-04-19 3:52 ` Liang Yang
2019-04-19 9:00 ` Miquel Raynal
2019-04-18 16:22 ` [PATCH 0/4] meson-nand: small code improvements Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ed284c1-ed34-9483-51a4-a79dfd0bd42c@amlogic.com \
--to=liang.yang@amlogic.com \
--cc=bbrezillon@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=jianxin.pan@amlogic.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).