From: David Hildenbrand <david@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com,
will.deacon@arm.com, ard.biesheuvel@arm.com, osalvador@suse.de,
mhocko@suse.com, mark.rutland@arm.com
Subject: Re: [PATCH V5 - Rebased] mm/hotplug: Reorder memblock_[free|remove]() calls in try_remove_memory()
Date: Thu, 13 Jun 2019 08:14:08 +0200 [thread overview]
Message-ID: <6ed925d3-03bf-14cb-3c3c-aeba6bbe20c7@redhat.com> (raw)
In-Reply-To: <20190612185450.73841b9f5af3a4189de6f910@linux-foundation.org>
On 13.06.19 03:54, Andrew Morton wrote:
> On Wed, 12 Jun 2019 08:53:33 +0200 David Hildenbrand <david@redhat.com> wrote:
>
>>>>> ...
>>>>>
>>>>>
>>>>> - Rebased on linux-next (next-20190611)
>>>>
>>>> Yet the patch you've prepared is designed for 5.3. Was that
>>>> deliberate, or should we be targeting earlier kernels?
>>>
>>> It was deliberate for 5.3 as a preparation for upcoming reworked arm64 hot-remove.
>>>
>>
>> We should probably add to the patch description something like "This is
>> a preparation for arm64 memory hotremove. The described issue is not
>> relevant on other architectures."
>
> Please. And is there any reason to merge it separately? Can it be
> [patch 1/3] in the "arm64/mm: Enable memory hot remove" series?
>
Nothing that the patch can be considered a cleanup:
"
mm/hotplug: Reorder memblock_[free|remove]() calls in try_remove_memory()
In add_memory_resource() we have:
memblock_add_node(start, size, nid)
...
arch_add_memory(nid, start, size, &restrictions);
...
create_memory_block_devices(start, size);
While in try_remove_memory() we have:
memblock_free(start, size);
memblock_remove(start, size);
...
remove_memory_block_devices(start, size);
arch_remove_memory(nid, start, size, NULL);
Let's restore the correct order by removing the memblock after
arch_remove_memory().
"
I think with such a description, we can include it now. Andrew?
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2019-06-13 16:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 9:16 [PATCH V5 0/3] arm64/mm: Enable memory hot remove Anshuman Khandual
2019-05-29 9:16 ` [PATCH V5 1/3] mm/hotplug: Reorder arch_remove_memory() call in __remove_memory() Anshuman Khandual
2019-05-30 10:37 ` Mark Rutland
2019-06-07 2:28 ` Anshuman Khandual
2019-06-07 7:43 ` David Hildenbrand
2019-06-11 11:26 ` [PATCH V5 - Rebased] mm/hotplug: Reorder memblock_[free|remove]() calls in try_remove_memory() Anshuman Khandual
2019-06-11 22:19 ` Andrew Morton
2019-06-12 4:02 ` Anshuman Khandual
2019-06-12 6:53 ` David Hildenbrand
2019-06-13 1:54 ` Andrew Morton
2019-06-13 5:37 ` Anshuman Khandual
2019-06-13 6:14 ` David Hildenbrand [this message]
2019-05-29 9:16 ` [PATCH V5 2/3] arm64/mm: Hold memory hotplug lock while walking for kernel page table dump Anshuman Khandual
2019-05-30 10:42 ` Mark Rutland
2019-05-29 9:16 ` [PATCH V5 3/3] arm64/mm: Enable memory hot remove Anshuman Khandual
2019-05-30 15:12 ` Mark Rutland
2019-06-11 14:43 ` Anshuman Khandual
2019-05-29 22:06 ` [PATCH V5 0/3] " Andrew Morton
2019-05-30 4:23 ` Anshuman Khandual
2019-05-30 7:23 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ed925d3-03bf-14cb-3c3c-aeba6bbe20c7@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=ard.biesheuvel@arm.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).