From: Wolfgang Grandegger <wg@grandegger.com>
To: Dan Murphy <dmurphy@ti.com>, mkl@pengutronix.de, davem@davemloft.net
Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Mario.Huettel" <Mario.Huettel@de.bosch.com>
Subject: Re: [PATCH 2/2] can: tcan4x5x: Add tcan4x5x driver to the kernel
Date: Fri, 5 Oct 2018 07:56:20 +0200 [thread overview]
Message-ID: <6f055cd9-9452-0b4c-2df2-3d0cc06f9e68@grandegger.com> (raw)
In-Reply-To: <7a75a096-d07f-693e-74b6-74a76c00acf5@ti.com>
Hello Dan,
Am 04.10.2018 um 22:26 schrieb Dan Murphy:
> Wolfgang
>
> On 09/26/2018 12:54 PM, Wolfgang Grandegger wrote:
>> Hello,
>>
>> I wonder why you do not extend the existing MCAN driver by implementing
>> an interface to access the hardware. Would that be feasible?
>>
>
> I have created a m_can_core code base that can be used by other hardware that
> have special needs.
>
> So I have created the m_can_core, m_can and the tcan4x5x drivers.
Great, I still think it's a good idea to have just one "m_can" driver.
> I can RFC the code to see if this is what is expected.
> It is not 100% working but it is close enough for a directional call.
That would be nice! Most of the SPI accesses are pure register accesses.
A few read/write more bytes at a time (for data, etc.) but that could be
handled by appropriate interface functions. One general problem is that
SPI accesses are not possible from interrupt context requiring threads
or work queues. Also NAPI is usually not used.
Other opinions?
Wolfgang.
PS: I have added Mario to the CC. Maybe he could test a common driver on
his M_CAN hardware.
next prev parent reply other threads:[~2018-10-05 5:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 20:12 [PATCH 1/2] dt-bindings: can: tcan4x5x: Add DT bindings for TCAN4x5X driver Dan Murphy
2018-09-10 20:12 ` [PATCH 2/2] can: tcan4x5x: Add tcan4x5x driver to the kernel Dan Murphy
2018-09-26 17:40 ` Dan Murphy
2018-09-26 17:54 ` Wolfgang Grandegger
2018-09-26 18:00 ` Dan Murphy
2018-09-26 18:34 ` Wolfgang Grandegger
2018-10-04 20:26 ` Dan Murphy
2018-10-05 5:56 ` Wolfgang Grandegger [this message]
2018-10-05 11:45 ` Dan Murphy
2018-09-26 17:40 ` [PATCH 1/2] dt-bindings: can: tcan4x5x: Add DT bindings for TCAN4x5X driver Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f055cd9-9452-0b4c-2df2-3d0cc06f9e68@grandegger.com \
--to=wg@grandegger.com \
--cc=Mario.Huettel@de.bosch.com \
--cc=davem@davemloft.net \
--cc=dmurphy@ti.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).