From: Allen Pais <apais@linux.microsoft.com>
To: Jens Wiklander <jens.wiklander@linaro.org>,
Allen Pais <allen.lkml@gmail.com>
Cc: zajec5@gmail.com, bcm-kernel-feedback-list@broadcom.com,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
op-tee@lists.trustedfirmware.org
Subject: Re: [PATCH v2 1/2] optee: fix tee out of memory failure seen during kexec reboot
Date: Tue, 2 Mar 2021 11:21:33 +0530 [thread overview]
Message-ID: <6f1c6529-7c89-21c9-0ce6-28545c251a9f@linux.microsoft.com> (raw)
In-Reply-To: <CAHUa44F5Ew6U80t7PPmV1J4KunXBm_izBxVrxg=x8azjBz0r9Q@mail.gmail.com>
>>
>> From: Allen Pais <apais@linux.microsoft.com>
>>
>> The following out of memory errors are seen on kexec reboot
>> from the optee core.
>>
>> [ 0.368428] tee_bnxt_fw optee-clnt0: tee_shm_alloc failed
>> [ 0.368461] tee_bnxt_fw: probe of optee-clnt0 failed with error -22
>>
>> tee_shm_release() is not invoked on dma shm buffer.
>>
>> Implement .shutdown() method to handle the release of the buffers
>> correctly.
>>
>> More info:
>> https://github.com/OP-TEE/optee_os/issues/3637
>>
>> Signed-off-by: Allen Pais <apais@linux.microsoft.com>
>> ---
>> drivers/tee/optee/core.c | 20 ++++++++++++++++++++
>> 1 file changed, 20 insertions(+)
>
> This looks good to me. Do you have a practical way of testing this on
> QEMU for instance?
I have not tried this on QEMU. I will give it a go today.
Thanks.
>
> Thanks,
> Jens
>
>>
>> diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c
>> index cf4718c6d35d..80e2774b5e2a 100644
>> --- a/drivers/tee/optee/core.c
>> +++ b/drivers/tee/optee/core.c
>> @@ -582,6 +582,13 @@ static optee_invoke_fn *get_invoke_func(struct device *dev)
>> return ERR_PTR(-EINVAL);
>> }
>>
>> +/* optee_remove - Device Removal Routine
>> + * @pdev: platform device information struct
>> + *
>> + * optee_remove is called by platform subsystem to alter the driver
>> + * that it should release the device
>> + */
>> +
>> static int optee_remove(struct platform_device *pdev)
>> {
>> struct optee *optee = platform_get_drvdata(pdev);
>> @@ -612,6 +619,18 @@ static int optee_remove(struct platform_device *pdev)
>> return 0;
>> }
>>
>> +/* optee_shutdown - Device Removal Routine
>> + * @pdev: platform device information struct
>> + *
>> + * platform_shutdown is called by the platform subsystem to alter
>> + * the driver that a shutdown/reboot(or kexec) is happening and
>> + * device must be disabled.
>> + */
>> +static void optee_shutdown(struct platform_device *pdev)
>> +{
>> + optee_disable_shm_cache(platform_get_drvdata(pdev));
>> +}
>> +
>> static int optee_probe(struct platform_device *pdev)
>> {
>> optee_invoke_fn *invoke_fn;
>> @@ -738,6 +757,7 @@ MODULE_DEVICE_TABLE(of, optee_dt_match);
>> static struct platform_driver optee_driver = {
>> .probe = optee_probe,
>> .remove = optee_remove,
>> + .shutdown = optee_shutdown,
>> .driver = {
>> .name = "optee",
>> .of_match_table = optee_dt_match,
>> --
>> 2.25.1
>>
next prev parent reply other threads:[~2021-03-02 8:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 9:06 [PATCH v2 0/2] optee: fix OOM seen due to tee_shm_free() Allen Pais
2021-02-25 9:06 ` [PATCH v2 1/2] optee: fix tee out of memory failure seen during kexec reboot Allen Pais
2021-03-01 14:35 ` Jens Wiklander
2021-03-02 5:51 ` Allen Pais [this message]
2021-03-16 13:21 ` Allen Pais
2021-03-19 7:00 ` Jens Wiklander
2021-03-22 7:59 ` Allen Pais
2021-05-05 13:45 ` Allen Pais
2021-05-06 7:02 ` Jens Wiklander
2021-05-06 7:10 ` Allen Pais
2021-05-06 7:19 ` Jens Wiklander
2021-05-06 7:29 ` Allen Pais
2021-05-06 8:15 ` Jens Wiklander
2021-05-06 8:35 ` Allen Pais
2021-05-07 7:03 ` Allen Pais
2021-03-18 20:51 ` Tyler Hicks
2021-02-25 9:06 ` [PATCH v2 2/2] firmware: tee_bnxt: implement shutdown method to handle kexec reboots Allen Pais
2021-03-18 20:55 ` Tyler Hicks
2021-05-07 3:58 ` [PATCH] optee: Disable shm cache when booting the crash kernel Tyler Hicks
2021-05-07 7:00 ` Allen Pais
2021-05-07 9:23 ` Jens Wiklander
2021-05-07 9:32 ` Allen Pais
2021-05-07 13:17 ` Tyler Hicks
2021-05-10 7:31 ` Jens Wiklander
2021-05-12 0:23 ` Tyler Hicks
2021-05-12 5:50 ` Jens Wiklander
2021-05-17 20:24 ` Tyler Hicks
2021-05-17 20:31 ` Tyler Hicks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f1c6529-7c89-21c9-0ce6-28545c251a9f@linux.microsoft.com \
--to=apais@linux.microsoft.com \
--cc=allen.lkml@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=jens.wiklander@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=op-tee@lists.trustedfirmware.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).