From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB67AC433E0 for ; Tue, 2 Mar 2021 07:48:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 916746146D for ; Tue, 2 Mar 2021 07:48:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1576592AbhCBEbX (ORCPT ); Mon, 1 Mar 2021 23:31:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345980AbhCBCKv (ORCPT ); Mon, 1 Mar 2021 21:10:51 -0500 Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C90BCC061225 for ; Mon, 1 Mar 2021 18:05:13 -0800 (PST) Received: by mail-io1-xd2b.google.com with SMTP id o9so5157599iow.6 for ; Mon, 01 Mar 2021 18:05:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=aHPldpe0SiR7sw8hK4soQ68kZblrZ1w3Ylxgm2V+BwM=; b=a6zRHktzbocHLE4UViU75DEfqkz5Q/iVvw3onXzt7SEfsaeXciR2lZ+a6vYp0nEe63 L4GLeBVICjWRT81J2ktA731yPNVxKZrqqkOis2JQtBijydOK3LiAwfZXJqbyTsrLSPVf jZayJOS5pvPH6fFfQYTUSXH50DWKjzUL5EE1k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aHPldpe0SiR7sw8hK4soQ68kZblrZ1w3Ylxgm2V+BwM=; b=qwQS4sU9Tq1umSuNBad5hdXc9f+ptXHTauB1BDT8lxmXZbXwSNwrOuMvdtlbG+Lqgr +ixsJMQ2B+4xIZuKqfIDH5J21OegDlD2y33w+wp5TTmMqI+9Epd8WmGYtOkj4E8o3JHb Ow1CnU7zimaSWS202YbI5VDYxaGJV1marWXZis3vF0HUGh5I3s5fipmkbeX55Wd3Ygt4 EMHZYToYVYfKTSHtJyz2G2vfaPSYFuho7r9yi50DIPt1v/IYWinIo2bg8h5ib4uljlhZ 5pfNerDA+3Vekh/6FWie+W8veWj+Jtx7ZShGoeEQw4vPK9IU+jeXZ9PyRHB2e6SJyh/j xWnQ== X-Gm-Message-State: AOAM531km5QsgXz28tzInDh4pldeyJ5Ffdr/s7WN7d4Vwr0L0ofE/0ZV ypJJqwBhikJ/1BKQIKUMxIrlrQ== X-Google-Smtp-Source: ABdhPJz5jUsHdnTFltQAarSJGMmnUhGxk7+zQ4ux/wKqpg5BGM/AjQx8Z418NkxEkBdNRuVxjyoFOA== X-Received: by 2002:a5d:8149:: with SMTP id f9mr16624787ioo.191.1614650713273; Mon, 01 Mar 2021 18:05:13 -0800 (PST) Received: from [172.22.22.26] (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.googlemail.com with ESMTPSA id y3sm1213633iot.15.2021.03.01.18.05.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Mar 2021 18:05:12 -0800 (PST) Subject: Re: [PATCH v1 3/7] net: ipa: gsi: Avoid some writes during irq setup for older IPA To: AngeloGioacchino Del Regno , elder@kernel.org Cc: bjorn.andersson@linaro.org, agross@kernel.org, davem@davemloft.net, kuba@kernel.org, linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, konrad.dybcio@somainline.org, marijn.suijten@somainline.org, phone-devel@vger.kernel.org References: <20210211175015.200772-1-angelogioacchino.delregno@somainline.org> <20210211175015.200772-4-angelogioacchino.delregno@somainline.org> From: Alex Elder Message-ID: <6f2ab23f-e4ab-2de8-1991-6a0435cfba65@ieee.org> Date: Mon, 1 Mar 2021 20:05:11 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210211175015.200772-4-angelogioacchino.delregno@somainline.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/11/21 11:50 AM, AngeloGioacchino Del Regno wrote: > On some IPA versions (v3.1 and older), writing to registers > GSI_INTER_EE_SRC_CH_IRQ_OFFSET and GSI_INTER_EE_SRC_EV_CH_IRQ_OFFSET > will generate a fault and the SoC will lockup. > > Avoid clearing CH and EV_CH interrupts on GSI probe to fix this bad > behavior: we are anyway not going to get spurious interrupts. I think the reason for this might be that these registers are located at a different offset for IPA v3.1. I'd rather get it right and actively disable these interrupts rather than assume they won't fire. Also... you included an extra blank line; avoid that. -Alex > Signed-off-by: AngeloGioacchino Del Regno > --- > drivers/net/ipa/gsi.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c > index 6315336b3ca8..b5460cbb085c 100644 > --- a/drivers/net/ipa/gsi.c > +++ b/drivers/net/ipa/gsi.c > @@ -207,11 +207,14 @@ static void gsi_irq_setup(struct gsi *gsi) > iowrite32(0, gsi->virt + GSI_CNTXT_SRC_IEOB_IRQ_MSK_OFFSET); > > /* Reverse the offset adjustment for inter-EE register offsets */ > - adjust = gsi->version < IPA_VERSION_4_5 ? 0 : GSI_EE_REG_ADJUST; > - iowrite32(0, gsi->virt + adjust + GSI_INTER_EE_SRC_CH_IRQ_OFFSET); > - iowrite32(0, gsi->virt + adjust + GSI_INTER_EE_SRC_EV_CH_IRQ_OFFSET); > + if (gsi->version > IPA_VERSION_3_1) { > + adjust = gsi->version < IPA_VERSION_4_5 ? 0 : GSI_EE_REG_ADJUST; > + iowrite32(0, gsi->virt + adjust + GSI_INTER_EE_SRC_CH_IRQ_OFFSET); > + iowrite32(0, gsi->virt + adjust + GSI_INTER_EE_SRC_EV_CH_IRQ_OFFSET); > + } > > iowrite32(0, gsi->virt + GSI_CNTXT_GSI_IRQ_EN_OFFSET); > + > } > > /* Turn off all GSI interrupts when we're all done */ >