From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Romain Izard <romain.izard.pro@gmail.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] clocksource: tcb_clksrc: Fix clock speed message
Date: Thu, 7 Dec 2017 12:01:45 +0100 [thread overview]
Message-ID: <6f3d309e-2e71-3f60-5910-0d8b1f051836@linaro.org> (raw)
In-Reply-To: <20171201122233.21828-1-romain.izard.pro@gmail.com>
On 01/12/2017 13:22, Romain Izard wrote:
> The clock speed displayed at boot in an information message was 500 kHz
> too high compared to its real value. As the value is not used anywhere,
> there is no functional impact.
>
> Fix the rounding formula to display the correct value.
>
> Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
> ---
> v2: rebase over v4.15-rc1
>
> There is no specified maintainer for this file, only supporters.
That is not correct, it defaults to Thomas and me, the maintainers of
drivers/clocksource :)
> Nicolas, could you pick this through the at91 tree as the TCB block
> is an AT91 peripheral ?
Nicolas, do you agree with this change ? If yes, I will take it.
> drivers/clocksource/tcb_clksrc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/tcb_clksrc.c b/drivers/clocksource/tcb_clksrc.c
> index 9de47d4d2d9e..43f4d5c4d6fa 100644
> --- a/drivers/clocksource/tcb_clksrc.c
> +++ b/drivers/clocksource/tcb_clksrc.c
> @@ -384,7 +384,7 @@ static int __init tcb_clksrc_init(void)
>
> printk(bootinfo, clksrc.name, CONFIG_ATMEL_TCB_CLKSRC_BLOCK,
> divided_rate / 1000000,
> - ((divided_rate + 500000) % 1000000) / 1000);
> + ((divided_rate % 1000000) + 500) / 1000);
> if (tc->tcb_config && tc->tcb_config->counter_width == 32) {
> /* use apropriate function to read 32 bit counter */
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2017-12-07 11:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 12:22 [PATCH v2] clocksource: tcb_clksrc: Fix clock speed message Romain Izard
2017-12-07 11:01 ` Daniel Lezcano [this message]
2017-12-07 16:34 ` Nicolas Ferre
2017-12-07 16:52 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f3d309e-2e71-3f60-5910-0d8b1f051836@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=romain.izard.pro@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).