From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 713C2C2D0E4 for ; Fri, 27 Nov 2020 12:49:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1BBE322248 for ; Fri, 27 Nov 2020 12:49:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="gnE6CEOv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729679AbgK0Mth (ORCPT ); Fri, 27 Nov 2020 07:49:37 -0500 Received: from mail.kernel.org ([198.145.29.99]:51034 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728910AbgK0Mtg (ORCPT ); Fri, 27 Nov 2020 07:49:36 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 56A2D22245; Fri, 27 Nov 2020 12:49:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606481376; bh=O/YqThBfV0DDchjNcPpY5nb4S87RvOgCC6KdsTcxMHA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gnE6CEOvCzJfmav0/QlzHQTBcVl0AcWoSvU46yV9nK/6MCbihTkMClU+VWa8qdKY+ XZLROqpdp35f5+JUzatV9ade1YtZRXQkS21ma8ZoouQKKlUIprssNUdjBQRzoUkrYU rZYbs/XYUWGWUbVtrFsaKofPGlxiIG51u+LdRO3o= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kidBt-00E3r9-6X; Fri, 27 Nov 2020 12:49:33 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 27 Nov 2020 12:49:33 +0000 From: Marc Zyngier To: John Garry Cc: Thomas Gleixner , gregkh@linuxfoundation.org, rafael@kernel.org, martin.petersen@oracle.com, jejb@linux.ibm.com, linuxarm@huawei.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] genirq/affinity: Add irq_update_affinity_desc() In-Reply-To: <113d72e1-a624-5da9-89cf-eee950e5c984@huawei.com> References: <87ft57r7v3.fsf@nanos.tec.linutronix.de> <78356caa-57a0-b807-fe52-8f12d36c1789@huawei.com> <874klmqu2r.fsf@nanos.tec.linutronix.de> <87lfexp6am.fsf@nanos.tec.linutronix.de> <3acb7fde-eae2-a223-9cfd-f409cc2abba6@huawei.com> <873615oy8a.fsf@nanos.tec.linutronix.de> <4aab9d3b-6ca6-01c5-f840-459f945c7577@huawei.com> <87sg91ik9e.wl-maz@kernel.org> <0edc9a11-0b92-537f-1790-6b4b6de4900d@huawei.com> <5a314713-c1ee-2d34-bee1-60beae274742@huawei.com> <0525a4bcf17a355cd141632d4f3714be@kernel.org> <702e1729-9a4b-b16f-6a58-33172b1a3220@huawei.com> <5a588f5d86010602ff9a90e8f057743c@kernel.org> <80e0a19b-3291-1304-1a5b-0445c49efe31@huawei.com> <696c04a9-8c13-0fec-08c4-068d4dd5ba67@huawei.com> <34953f2d7b61f37ab1333627dc256975@kernel.org> <113d72e1-a624-5da9-89cf-eee950e5c984@huawei.com> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <6f3e8b84867936a8301fc3ec62533df9@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: john.garry@huawei.com, tglx@linutronix.de, gregkh@linuxfoundation.org, rafael@kernel.org, martin.petersen@oracle.com, jejb@linux.ibm.com, linuxarm@huawei.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-11-27 12:45, John Garry wrote: > On 27/11/2020 09:57, Marc Zyngier wrote: >>> If I understand the code correctly, MSI_ALLOC_FLAGS_SHARED_DEVICE is >>> supposed to be set in info->flags in platform_msi_set_desc(), but >>> this >>> is called per-msi after its_msi_prepare(), so we don't the flags set >>> at the right time. That's how it looks to me... >> >> Meh. I was trying multiple things, and of course commited the worse >> possible approach. >> >> I've updated the branch, having verified that we do get the flag in >> the ITS now. > > Hi Marc, > > That looks to work. Thanks for having given it a go. > So do you have an upstream plan for this? I ask, as if you go with > this, then I may change my series to map and unmap all the irqs again > - but not sure about that. I'll write some commit messages, and post that. Either this weekend, or on Monday at the latest. Thanks, M. -- Jazz is not dead. It just smells funny...