From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S935705AbcIGQ5u (ORCPT <rfc822;w@1wt.eu>);
        Wed, 7 Sep 2016 12:57:50 -0400
Received: from mout.web.de ([212.227.17.11]:49235 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932898AbcIGQ5r (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 7 Sep 2016 12:57:47 -0400
Subject: Re: x86-ksysfs: Use kmalloc_array() in create_setup_data_nodes()
To: Kees Cook <keescook@chromium.org>
References: <3b21b2d7-9856-009c-9bd1-3a76a83bc7fc@users.sourceforge.net>
 <CAGXu5jLSsU+daPP=uX+3T02RkTFguG1rtemOF-7Py_Fi=qYP6A@mail.gmail.com>
 <e24dae2d-b55a-d90a-9934-080e6165802b@users.sourceforge.net>
 <f1caa945-b808-f6b5-6047-35c43330431f@redhat.com>
 <f9edcf05-482e-dfbb-b661-c070ee1debf4@users.sourceforge.net>
 <3eea073a-b271-54b7-1eec-e841e0f4bdf9@redhat.com>
 <07f2cb49-662f-590f-acf6-686f8432015d@users.sourceforge.net>
 <CAGXu5jJ=YsdYegd3L2RzPKA9OGxE2vzo7U8BQjgK+qAaxEu0pQ@mail.gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Ingo Molnar <mingo@redhat.com>,
        "x86@kernel.org" <x86@kernel.org>, Dave Young <dyoung@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Matt Fleming <matt.fleming@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        Julia Lawall <julia.lawall@lip6.fr>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <6f626c15-aac1-a0ad-402a-425874e4908e@users.sourceforge.net>
Date: Wed, 7 Sep 2016 18:55:09 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <CAGXu5jJ=YsdYegd3L2RzPKA9OGxE2vzo7U8BQjgK+qAaxEu0pQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:FEJu1S+LblABiEukJjpq+asXkFq6ExVtTli8mpZR6scH6xN6TXL
 goG7yfdHqEsoy2VjH/c0XHyjd6iC1uo+C1jiEsZa8UDACzQcgnEHexWJ4gnjwaePGqxZnKC
 eiBDT0EvLCy15TrLvMTRtuCyNhblkORjmtcIvqkPGoWTQAAxFlRbT2WYbjubwNQPpou8sSe
 adG6q5deb2nZvG3U20rvQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:qmrK9HI3KDE=:5ctGyrqEv1fQJM/kMm9Zm3
 nWewSwZQjBxpuOy61BuXsUg3vwqrkUIp28KLFUAmhv/+yxEL/hMMZ5PVctoo6wH5gAKlJoahs
 NUAIsfxsnb7zArdzMaxBAofld2HP0FUb4pFoWe23IwamqOYCHzpPFM8NSQyDO2N6TQawcT3Hw
 D60Xd2relVkQW1EJpul1JN12JrnAM/KgceBghd5WM+zZNrsVaC0dNLYHFWEawvYIzdBgIvkl9
 9GdGZTHAWUXa12Ou4BfhhN0bJr7kvAtLDR3xHItdPFdLjLohx88MkzvTsCu7CroGuFOU9g3WY
 q68QdmHgKXzLq21nxiFR4i8dnzPTFo/cF9ALuhbbOkbH3JVLvy3hLgyiKn/7pdXZNMA2fgdnC
 Pm1K4uvARER23Y5l7By1dpOOYE+DXGovXV21xn+mBwsx+USnEdp2ndWjLLtAgLtnNLqtFoqMt
 u+AemSgimsPibIYBQjYVRHxJurLo8J4ninDUUsykjzXExFMZ5imR+eDt1OBSybQKoGEoRq4GJ
 3pq02F320r5ur6EJQWxP62Lf1rEDC9fghtqUhTO6pUQLbP9qIdGN9TPcvwJ2Y2VNNQuFJEeGA
 6+9XkO7TcYv4LaCxgr3bOx1a/t2EwvF0YJfVJysj7pjZNrqDryZXp4OXdBsAmTsoCf+lDtftX
 uMHy6Sd8VYZuQ+gC4dbNxzPoUAmE5SRgn10DJZIj0bGbnOcfOfBQvnzSAPhD7dXzXUWe2zKfe
 zrLkGJ+iaVwdi7//5rv9bzfLll/4q45vBrpwPgklJSN5RutRNrNDzSr1ouLEC52Kwp7GFPhWk
 X5y1/Pi
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Fixing these kmalloc calls would be a nice thing to clean up everywhere.

Thanks for your acknowledgement of such a software improvement opportunity.


> Since it is a mistake people may continue to make, I think it would
> make sense to add a coccinelle script that can do this to the
> existing coccinelle scripts in the kernel if one to do it does not
> already exist. That way, it will be part of the coccinelle checking
> that is automatically run on the kernel regularly.

I am curious on how many contributors would like to help a bit more
in such a software development task.

How do you think about to clarify corresponding challenges better?

Do you find any details interesting which are described in a feature
request (or article) like "Improve determination of sizes with SmPL"?
https://github.com/coccinelle/coccinelle/issues/80

Regards,
Markus