From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: David Heidelberg <david@ixit.cz>,
Manivannan Sadhasivam <mani@kernel.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: mailbox: qcom-ipcc: add missing compatible for SM8450
Date: Mon, 25 Apr 2022 15:51:08 +0200 [thread overview]
Message-ID: <6f72be3c-c907-bc7a-6b64-6becfc76934e@linaro.org> (raw)
In-Reply-To: <20220425134717.55418-1-david@ixit.cz>
On 25/04/2022 15:47, David Heidelberg wrote:
> Adds forgotten compatible and update SPDX header.
You need to explain what is this "forgotten compatible". It's to vague.
The SPDX update lacks answer to "why". There is no reason to do it, so
please explain why it is needed.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-25 13:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 13:47 [PATCH v3 1/2] dt-bindings: mailbox: qcom-ipcc: add missing compatible for SM8450 David Heidelberg
2022-04-25 13:47 ` [PATCH v3 2/2] dt-bindings: mailbox: qcom-ipcc: add missing properties into example David Heidelberg
2022-04-25 13:51 ` Krzysztof Kozlowski [this message]
2022-04-25 14:05 ` [PATCH v3 1/2] dt-bindings: mailbox: qcom-ipcc: add missing compatible for SM8450 David Heidelberg
2022-04-25 14:11 ` Krzysztof Kozlowski
2022-04-26 0:53 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f72be3c-c907-bc7a-6b64-6becfc76934e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).