From: Florian Fainelli <f.fainelli@gmail.com>
To: "Álvaro Fernández Rojas" <noltari@gmail.com>,
andrew@lunn.ch, olteanv@gmail.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] net: dsa: b53: add BCM63268 RGMII configuration
Date: Mon, 20 Mar 2023 13:00:15 -0700 [thread overview]
Message-ID: <6f7e9b8c-6256-e7dd-b130-8e1429610faa@gmail.com> (raw)
In-Reply-To: <20230320155024.164523-5-noltari@gmail.com>
On 3/20/23 08:50, Álvaro Fernández Rojas wrote:
> BCM63268 requires special RGMII configuration to work.
>
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> ---
> drivers/net/dsa/b53/b53_common.c | 6 +++++-
> drivers/net/dsa/b53/b53_regs.h | 1 +
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c
> index 6e212f6f1cb9..d0a22c8a55c9 100644
> --- a/drivers/net/dsa/b53/b53_common.c
> +++ b/drivers/net/dsa/b53/b53_common.c
> @@ -1240,8 +1240,12 @@ static void b53_adjust_63xx_rgmii(struct dsa_switch *ds, int port,
> break;
> }
>
> - if (port != dev->imp_port)
> + if (port != dev->imp_port) {
> + if (is63268(dev))
> + rgmii_ctrl |= RGMII_CTRL_MII_OVERRIDE;
AFAICT the override bit is defined and valid for both 63268 and 6318,
essentially whenever more than one RGMII control register for port 4,
but also for other ports, it seems like the bit becomes valid. The
comment I have says that the override bit ensures that what is populated
in bits 5:4 which is the actual RGMII interface mode is applied. That
mode can be one of:
0b00: RGMII mode
0b01: MII mode
0b10: RVMII mode
0b11: GMII mode
even though this is not documented as such, I suspect that the override
bit does not only set the mode, but also ensures that the delays are
also applied.
Once you update patch 3, this LGTM and you may add:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
For your v2. Thanks!
--
Florian
next prev parent reply other threads:[~2023-03-20 20:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 15:50 [PATCH 0/4] net: dsa: b53: configure BCM63268 RGMII ports Álvaro Fernández Rojas
2023-03-20 15:50 ` [PATCH 1/4] dt-bindings: net: dsa: b53: add more 63xx SoCs Álvaro Fernández Rojas
2023-03-20 19:49 ` Simon Horman
2023-03-20 19:51 ` Florian Fainelli
2023-03-21 7:14 ` Krzysztof Kozlowski
2023-03-20 15:50 ` [PATCH 2/4] net: dsa: b53: mmap: add more BCM63xx SoCs Álvaro Fernández Rojas
2023-03-20 19:52 ` Florian Fainelli
2023-03-20 19:54 ` Simon Horman
2023-03-20 19:56 ` Álvaro Fernández Rojas
2023-03-20 20:11 ` Simon Horman
2023-03-20 15:50 ` [PATCH 3/4] net: dsa: b53: mmap: allow passing a chip ID Álvaro Fernández Rojas
2023-03-20 19:57 ` Florian Fainelli
2023-03-20 20:01 ` Simon Horman
2023-03-20 15:50 ` [PATCH 4/4] net: dsa: b53: add BCM63268 RGMII configuration Álvaro Fernández Rojas
2023-03-20 20:00 ` Florian Fainelli [this message]
2023-03-21 9:10 ` Álvaro Fernández Rojas
2023-03-20 20:07 ` Simon Horman
2023-03-21 17:33 ` [PATCH v2 0/4] net: dsa: b53: configure 6318 and 63268 RGMII ports Álvaro Fernández Rojas
2023-03-21 17:33 ` [PATCH v2 1/4] dt-bindings: net: dsa: b53: add more 63xx SoCs Álvaro Fernández Rojas
2023-03-21 17:33 ` [PATCH v2 2/4] net: dsa: b53: mmap: " Álvaro Fernández Rojas
2023-03-22 11:11 ` Simon Horman
2023-03-21 17:33 ` [PATCH v2 3/4] net: dsa: b53: mmap: allow passing a chip ID Álvaro Fernández Rojas
2023-03-21 18:19 ` Florian Fainelli
2023-03-22 11:12 ` Simon Horman
2023-03-21 17:33 ` [PATCH v2 4/4] net: dsa: b53: add BCM63268 RGMII configuration Álvaro Fernández Rojas
2023-03-23 4:50 ` [PATCH v2 0/4] net: dsa: b53: configure 6318 and 63268 RGMII ports patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f7e9b8c-6256-e7dd-b130-8e1429610faa@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=noltari@gmail.com \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).