From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev,
Kamel Bouhara <kamel.bouhara@bootlin.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Henrik Rydberg <rydberg@bitmath.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Marco Felsch <m.felsch@pengutronix.de>,
Jeff LaBundy <jeff@labundy.com>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
catalin.popescu@leica-geosystems.com,
mark.satterthwaite@touchnetix.com, bartp@baasheep.co.uk,
hannah.rossiter@touchnetix.com,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Gregory Clement <gregory.clement@bootlin.com>,
bsp-development.geo@leica-geosystems.com,
Kamel Bouhara <kamel.bouhara@bootlin.com>
Subject: Re: [PATCH v4 3/3] Input: Add TouchNetix axiom i2c touchscreen driver
Date: Thu, 7 Dec 2023 08:28:15 +0300 [thread overview]
Message-ID: <6f8e3b64-5b21-4a50-8680-063ef7a93bdb@suswa.mountain> (raw)
In-Reply-To: <20231204140505.2838916-4-kamel.bouhara@bootlin.com>
Hi Kamel,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Kamel-Bouhara/dt-bindings-vendor-prefixes-Add-TouchNetix-AS/20231204-222017
base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
patch link: https://lore.kernel.org/r/20231204140505.2838916-4-kamel.bouhara%40bootlin.com
patch subject: [PATCH v4 3/3] Input: Add TouchNetix axiom i2c touchscreen driver
config: i386-randconfig-r071-20231206 (https://download.01.org/0day-ci/archive/20231207/202312070608.vxtNAYhk-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231207/202312070608.vxtNAYhk-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202312070608.vxtNAYhk-lkp@intel.com/
smatch warnings:
drivers/input/touchscreen/touchnetix_axiom.c:565 axiom_i2c_probe() warn: passing zero to 'PTR_ERR'
vim +/PTR_ERR +565 drivers/input/touchscreen/touchnetix_axiom.c
a9f3450f06a026 Kamel Bouhara 2023-12-04 536 static int axiom_i2c_probe(struct i2c_client *client)
a9f3450f06a026 Kamel Bouhara 2023-12-04 537 {
a9f3450f06a026 Kamel Bouhara 2023-12-04 538 struct device *dev = &client->dev;
a9f3450f06a026 Kamel Bouhara 2023-12-04 539 struct input_dev *input_dev;
a9f3450f06a026 Kamel Bouhara 2023-12-04 540 struct axiom_data *ts;
a9f3450f06a026 Kamel Bouhara 2023-12-04 541 u32 startup_delay_ms;
a9f3450f06a026 Kamel Bouhara 2023-12-04 542 u32 poll_interval;
a9f3450f06a026 Kamel Bouhara 2023-12-04 543 int target;
a9f3450f06a026 Kamel Bouhara 2023-12-04 544 int error;
a9f3450f06a026 Kamel Bouhara 2023-12-04 545
a9f3450f06a026 Kamel Bouhara 2023-12-04 546 ts = devm_kzalloc(dev, sizeof(*ts), GFP_KERNEL);
a9f3450f06a026 Kamel Bouhara 2023-12-04 547 if (!ts)
a9f3450f06a026 Kamel Bouhara 2023-12-04 548 return -ENOMEM;
a9f3450f06a026 Kamel Bouhara 2023-12-04 549
a9f3450f06a026 Kamel Bouhara 2023-12-04 550 ts->client = client;
a9f3450f06a026 Kamel Bouhara 2023-12-04 551 i2c_set_clientdata(client, ts);
a9f3450f06a026 Kamel Bouhara 2023-12-04 552 ts->dev = dev;
a9f3450f06a026 Kamel Bouhara 2023-12-04 553
a9f3450f06a026 Kamel Bouhara 2023-12-04 554 ts->reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
a9f3450f06a026 Kamel Bouhara 2023-12-04 555 if (IS_ERR(ts->reset_gpio))
a9f3450f06a026 Kamel Bouhara 2023-12-04 556 return dev_err_probe(dev, PTR_ERR(ts->reset_gpio), "failed to get reset GPIO\n");
a9f3450f06a026 Kamel Bouhara 2023-12-04 557
a9f3450f06a026 Kamel Bouhara 2023-12-04 558 if (ts->reset_gpio)
a9f3450f06a026 Kamel Bouhara 2023-12-04 559 axiom_reset(ts->reset_gpio);
a9f3450f06a026 Kamel Bouhara 2023-12-04 560
a9f3450f06a026 Kamel Bouhara 2023-12-04 561 ts->vddi = devm_regulator_get_optional(dev, "VDDI");
a9f3450f06a026 Kamel Bouhara 2023-12-04 562 if (!IS_ERR(ts->vddi)) {
a9f3450f06a026 Kamel Bouhara 2023-12-04 563 error = regulator_enable(ts->vddi);
a9f3450f06a026 Kamel Bouhara 2023-12-04 564 if (error)
a9f3450f06a026 Kamel Bouhara 2023-12-04 @565 return dev_err_probe(&client->dev, PTR_ERR(ts->vddi),
^^^^^^^^^^^^^^^^^^
s/PTR_ERR(ts->vddi)/error/
a9f3450f06a026 Kamel Bouhara 2023-12-04 566 "Failed to enable VDDI regulator\n");
a9f3450f06a026 Kamel Bouhara 2023-12-04 567 }
a9f3450f06a026 Kamel Bouhara 2023-12-04 568
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
prev parent reply other threads:[~2023-12-07 5:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 14:05 [PATCH v4 0/3] Input: Add TouchNetix axiom touchscreen driver Kamel Bouhara
2023-12-04 14:05 ` [PATCH v4 1/3] dt-bindings: vendor-prefixes: Add TouchNetix AS Kamel Bouhara
2023-12-04 14:05 ` [PATCH v4 2/3] dt-bindings: input: Add TouchNetix axiom touchscreen Kamel Bouhara
2023-12-05 8:15 ` Krzysztof Kozlowski
2023-12-05 9:17 ` Kamel BOUHARA
2023-12-05 9:26 ` Krzysztof Kozlowski
2023-12-04 14:05 ` [PATCH v4 3/3] Input: Add TouchNetix axiom i2c touchscreen driver Kamel Bouhara
2023-12-04 15:09 ` POPESCU Catalin
2023-12-04 16:16 ` Kamel Bouhara
2023-12-05 6:36 ` kernel test robot
2023-12-07 5:28 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f8e3b64-5b21-4a50-8680-063ef7a93bdb@suswa.mountain \
--to=dan.carpenter@linaro.org \
--cc=bartp@baasheep.co.uk \
--cc=bsp-development.geo@leica-geosystems.com \
--cc=catalin.popescu@leica-geosystems.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregory.clement@bootlin.com \
--cc=hannah.rossiter@touchnetix.com \
--cc=jeff@labundy.com \
--cc=kamel.bouhara@bootlin.com \
--cc=krzk@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=m.felsch@pengutronix.de \
--cc=mark.satterthwaite@touchnetix.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=robh+dt@kernel.org \
--cc=rydberg@bitmath.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).