[PATCH] security/smack: remove unused varible 'rc'

[PATCH] security/smack: remove unused varible 'rc'

[Alex Shi]

This varible isn't used and can be removed to avoid a gcc warning:
security/smack/smack_lsm.c:3873:6: warning: variable ‘rc’ set but not
used [-Wunused-but-set-variable]

Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
Cc: Casey Schaufler <casey@schaufler-ca.com> 
Cc: James Morris <jmorris@namei.org> 
Cc: "Serge E. Hallyn" <serge@hallyn.com> 
Cc: linux-security-module@vger.kernel.org 
Cc: linux-kernel@vger.kernel.org 
---
 security/smack/smack_lsm.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
index 5c90b9fa4d40..9994fcfafd70 100644
--- a/security/smack/smack_lsm.c
+++ b/security/smack/smack_lsm.c
@@ -3870,7 +3870,6 @@ static struct smack_known *smack_from_netlbl(struct sock *sk, u16 family,
 	struct netlbl_lsm_secattr secattr;
 	struct socket_smack *ssp = NULL;
 	struct smack_known *skp = NULL;
-	int rc;
 
 	netlbl_secattr_init(&secattr);
 
@@ -3880,7 +3879,7 @@ static struct smack_known *smack_from_netlbl(struct sock *sk, u16 family,
 	if (netlbl_skbuff_getattr(skb, family, &secattr) == 0) {
 		skp = smack_from_secattr(&secattr, ssp);
 		if (secattr.flags & NETLBL_SECATTR_CACHEABLE)
-			rc = netlbl_cache_add(skb, family, &skp->smk_netlabel);
+			netlbl_cache_add(skb, family, &skp->smk_netlabel);
 	}
 
 	netlbl_secattr_destroy(&secattr);
-- 
1.8.3.1

Re: [PATCH] security/smack: remove unused varible 'rc'

[Casey Schaufler]

On 11/7/2020 10:45 PM, Alex Shi wrote:
> This varible isn't used and can be removed to avoid a gcc warning:
> security/smack/smack_lsm.c:3873:6: warning: variable ‘rc’ set but not
> used [-Wunused-but-set-variable]
>
> Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
> Cc: Casey Schaufler <casey@schaufler-ca.com> 
> Cc: James Morris <jmorris@namei.org> 
> Cc: "Serge E. Hallyn" <serge@hallyn.com> 
> Cc: linux-security-module@vger.kernel.org 
> Cc: linux-kernel@vger.kernel.org 

I will take this through the Smack tree. Thank you.

> ---
>  security/smack/smack_lsm.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
> index 5c90b9fa4d40..9994fcfafd70 100644
> --- a/security/smack/smack_lsm.c
> +++ b/security/smack/smack_lsm.c
> @@ -3870,7 +3870,6 @@ static struct smack_known *smack_from_netlbl(struct sock *sk, u16 family,
>  	struct netlbl_lsm_secattr secattr;
>  	struct socket_smack *ssp = NULL;
>  	struct smack_known *skp = NULL;
> -	int rc;
>  
>  	netlbl_secattr_init(&secattr);
>  
> @@ -3880,7 +3879,7 @@ static struct smack_known *smack_from_netlbl(struct sock *sk, u16 family,
>  	if (netlbl_skbuff_getattr(skb, family, &secattr) == 0) {
>  		skp = smack_from_secattr(&secattr, ssp);
>  		if (secattr.flags & NETLBL_SECATTR_CACHEABLE)
> -			rc = netlbl_cache_add(skb, family, &skp->smk_netlabel);
> +			netlbl_cache_add(skb, family, &skp->smk_netlabel);
>  	}
>  
>  	netlbl_secattr_destroy(&secattr);