From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161084AbdAEI1o (ORCPT ); Thu, 5 Jan 2017 03:27:44 -0500 Received: from mx2.suse.de ([195.135.220.15]:50812 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1033228AbdAEI0d (ORCPT ); Thu, 5 Jan 2017 03:26:33 -0500 Subject: Re: [PATCH 0/7 v2] vm, vmscan: enahance vmscan tracepoints To: Michal Hocko , Andrew Morton References: <20170104101942.4860-1-mhocko@kernel.org> Cc: Mel Gorman , Johannes Weiner , Minchan Kim , Hillf Danton , linux-mm@kvack.org, LKML From: Vlastimil Babka Message-ID: <6fc43646-8ae5-aa54-6fe0-8503d50ef6c8@suse.cz> Date: Thu, 5 Jan 2017 09:25:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170104101942.4860-1-mhocko@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/04/2017 11:19 AM, Michal Hocko wrote: > Hi, > this is the second version of the patchset [1]. I hope I've addressed all > the review feedback. > > While debugging [2] I've realized that there is some room for > improvements in the tracepoints set we offer currently. I had hard times > to make any conclusion from the existing ones. The resulting problem > turned out to be active list aging [3] and we are missing at least two > tracepoints to debug such a problem. > > Some existing tracepoints could export more information to see _why_ the > reclaim progress cannot be made not only _how much_ we could reclaim. > The later could be seen quite reasonably from the vmstat counters > already. It can be argued that we are showing too many implementation > details in those tracepoints but I consider them way too lowlevel > already to be usable by any kernel independent userspace. I would be > _really_ surprised if anything but debugging tools have used them. > > Any feedback is highly appreciated. When patch-specific feedback is addressed, then for the whole series: Acked-by: Vlastimil Babka > [1] http://lkml.kernel.org/r/20161228153032.10821-1-mhocko@kernel.org > [2] http://lkml.kernel.org/r/20161215225702.GA27944@boerne.fritz.box > [3] http://lkml.kernel.org/r/20161223105157.GB23109@dhcp22.suse.cz > >