From: Thorsten Leemhuis <regressions@leemhuis.info>
To: Basavaraj Natikar <bnatikar@amd.com>,
Basavaraj Natikar <Basavaraj.Natikar@amd.com>
Cc: Jiri Kosina <jkosina@suse.cz>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"regressions@lists.linux.dev" <regressions@lists.linux.dev>,
Marco <rodomar705@protonmail.com>
Subject: Re: Bug 215744 - input from the accelerometer disappeared, regression on amd_sfh on kernel 5.17
Date: Mon, 4 Apr 2022 08:35:04 +0200 [thread overview]
Message-ID: <6fe27103-5e35-5f16-d213-29bd71412f5b@leemhuis.info> (raw)
In-Reply-To: <0499f8ae-6966-be4b-5af8-e7e568bfcd5f@amd.com>
On 01.04.22 21:47, Basavaraj Natikar wrote:
>
> Committed patch is disabling the interrupt mode and does not cause any
> functionality or working issues.
Well, for the reporter it clearly does cause problems, unless something
in testing went sideways.
> I also cross verified on 3 system and working fine on 5.17 and not able
> to reproduce or recreate.
> [...]
> ------------------------------------------------
>
> Looks like this is not regression. May be some hardware/firmware bug.
Well, from the point of the kernel development process it afaics is a
regression, unless the testing went sideways. It doesn't matter if the
root cause is in fact a hardware/firmware bug, as what matters in the
scope of the kernel development is: things worked, and now they don't.
For details please check this file and read the quotes from Linus:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/plain/Documentation/process/handling-regressions.rst
Ciao, Thorsten
> Just curious reverting this patch how it is working just suspecting
> firmware undefined behavior.
>
> If possible, please check on other platform/system also if same behavior
> occurs.
>
> Could you please provide me platform/system details so that I can check
> this behavior?
>
> Thanks,
> Basavaraj
>
> On 4/1/2022 1:36 PM, Thorsten Leemhuis wrote:
>> Hi, this is your Linux kernel regression tracker.
>>
>> I noticed a regression report in bugzilla.kernel.org that afaics nobody
>> acted upon since it was reported about a week ago, that's why I decided
>> to forward it to the lists and all people that seemed to be relevant
>> here. It looks to me like this is something for Basavaraj, as it seems
>> to be caused by b300667b33b2 ("HID: amd_sfh: Disable the interrupt for
>> all command"). But I'm not totally sure, I only looked briefly into the
>> details. Or was this discussed somewhere else already? Or even fixed?
>>
>> To quote from https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.kernel.org%2Fshow_bug.cgi%3Fid%3D215744&data=04%7C01%7CBasavaraj.Natikar%40amd.com%7C9155f6987d45479f721208da13b682f9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637843972013904577%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=HbQ5LymDwsc94RZhNuzN83%2F0BUplqRUG7bB%2BXymViP0%3D&reserved=0 :
>>
>>> Marco 2022-03-25 15:22:19 UTC
>>>
>>> After updating to 5.17, the input from the accelerometer disappeared, completely. No devices available from IIO tree. First bad commit causing it is https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git%2Fcommit%2Fdrivers%2Fhid%2Famd-sfh-hid%2Famd_sfh_pcie.c%3Fid%3Db300667b33b2b5a2c8e5f8f22826befb3d7f4f2b&data=04%7C01%7CBasavaraj.Natikar%40amd.com%7C9155f6987d45479f721208da13b682f9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637843972013904577%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=odHA0EIxLb0xpSJJ9ShzgGL0%2BOAJ6tbG68lQe0QOqLY%3D&reserved=0. Reverting this and the the other two on top fixed this. Tried to not revert only the above mentioned commit, but it's still not working.
>>>
>>> Marco.
>> Anyway, to get this tracked:
>>
>> #regzbot introduced: b300667b33b2b5a2c8e5f8f22826befb3d7f4
>> #regzbot from: Marco <rodomar705@protonmail.com>
>> #regzbot title: input: hid: input from the accelerometer disappeared due
>> to changes to amd_sfh
>> #regzbot link: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.kernel.org%2Fshow_bug.cgi%3Fid%3D215744&data=04%7C01%7CBasavaraj.Natikar%40amd.com%7C9155f6987d45479f721208da13b682f9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637843972013904577%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=HbQ5LymDwsc94RZhNuzN83%2F0BUplqRUG7bB%2BXymViP0%3D&reserved=0
>>
>> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
>>
>> P.S.: As the Linux kernel's regression tracker I'm getting a lot of
>> reports on my table. I can only look briefly into most of them and lack
>> knowledge about most of the areas they concern. I thus unfortunately
>> will sometimes get things wrong or miss something important. I hope
>> that's not the case here; if you think it is, don't hesitate to tell me
>> in a public reply, it's in everyone's interest to set the public record
>> straight.
>>
>
>
next prev parent reply other threads:[~2022-04-04 6:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 8:06 Bug 215744 - input from the accelerometer disappeared, regression on amd_sfh on kernel 5.17 Thorsten Leemhuis
2022-04-01 19:47 ` Basavaraj Natikar
2022-04-04 6:35 ` Thorsten Leemhuis [this message]
2022-04-04 7:18 ` Basavaraj Natikar
2022-04-04 7:25 ` Thorsten Leemhuis
2022-04-04 13:53 ` Thorsten Leemhuis
2022-04-04 14:04 ` Basavaraj Natikar
[not found] ` <-IeN6GQXuvFeZGmf-HSltWI3MN3V02oQzXAW0XR74vD62w_Fo_A6lSfJXrDgV2MTrHs9Id2Ce_r9J_zZCKx67DnVAWeFg3-ULIZ2GSm_ITQ=@protonmail.com>
2022-04-04 17:40 ` Marco
2022-04-17 17:16 ` Marco
2022-04-21 9:15 ` Benjamin Tissoires
2022-04-21 9:24 ` Basavaraj Natikar
2022-04-29 11:34 ` Bug 215744 - input from the accelerometer disappeared, regression on amd_sfh on kernel 5.17 #forregzbot Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fe27103-5e35-5f16-d213-29bd71412f5b@leemhuis.info \
--to=regressions@leemhuis.info \
--cc=Basavaraj.Natikar@amd.com \
--cc=benjamin.tissoires@redhat.com \
--cc=bnatikar@amd.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=regressions@lists.linux.dev \
--cc=rodomar705@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).