From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Nicolas Belin <nbelin@baylibre.com>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
pavel@ucw.cz, dmurphy@ti.com, devicetree@vger.kernel.org
Cc: baylibre-upstreaming@groups.io
Subject: Re: [PATCH v3 2/3] dt-bindings: leds: Shiji Lighting APA102C LED
Date: Fri, 6 Mar 2020 21:19:57 +0100 [thread overview]
Message-ID: <70129275-087a-fd85-c771-5d72e591d190@gmail.com> (raw)
In-Reply-To: <1583502010-16210-3-git-send-email-nbelin@baylibre.com>
Hi Nicolas,
On 3/6/20 2:40 PM, Nicolas Belin wrote:
> Document Shiji Lighting APA102C LED driver device tree bindings.
>
> Signed-off-by: Nicolas Belin <nbelin@baylibre.com>
> ---
> .../devicetree/bindings/leds/leds-apa102c.yaml | 97 ++++++++++++++++++++++
> 1 file changed, 97 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/leds-apa102c.yaml
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-apa102c.yaml b/Documentation/devicetree/bindings/leds/leds-apa102c.yaml
> new file mode 100644
> index 000000000000..21457fc3762d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-apa102c.yaml
> @@ -0,0 +1,97 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/leds-apa102c.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LED driver for Shiji Lighting - APA102C
> +
> +maintainers:
> + - Nicolas Belin <nbelin@baylibre.com>
> +
> +description:
> + Each RGB LED is represented as a rgb-led sub-node of the leds-apa102c
> + device. Each LED is a three color rgb LED with an additional 32 levels
> + brightness adjustment. They can be cascaded so that multiple LEDs can be set
> + with a single command.
> +
> +properties:
> + compatible:
> + const: shiji,apa102c
> +
> + reg:
> + maxItems: 1
> +
> + spi-max-frequency:
> + maximum: 1000000
> +
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
> +
> +patternProperties:
> + "^rgb-led@[0-9]+$":
> + type: object
> + description: |
> + Array of connected RGB LEDs.
> +
> + properties:
> + reg:
> + description: |
> + This property corresponds to the led index. It has to be between 0
> + and the number of managed leds minus 1
> + maxItems: 1
> +
> + label:
As mentioned before - don't use label and use function
and color properties instead.
> + description: |
> + This property corresponds to the name of the RGB led.
> + maxItems: 1
> +
> + linux,default-trigger: true
> +
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
> +
> + required:
> + - reg
> + - label
> + - '#address-cells'
> + - '#size-cells'
> +
> +required:
> + - compatible
> + - reg
> + - spi-max-frequency
> + - '#address-cells'
> + - '#size-cells'
> +
> +examples:
> + - |
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + led-controller@0 {
> + compatible = "shiji,apa102c";
> + reg = <0>;
> + spi-max-frequency = <1000000>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + rgb-led@0 {
s/rgb-led/led/
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0>;
> + label = "rgb_led1";
Instead of label please use function and color properties.
E.g.
color = LED_COLOR_ID_RED;
function = LED_FUNCTION_STATUS;
If the function of your interest is not available in
include/dt-bindings/leds/common.h then you can propose one.
Please refer to Documentation/devicetree/bindings/leds/common.txt.
> + };
> + rgb-led@1 {
s/rgb-led/led/
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <1>;
> + label = "rgb_led2";
> + };
You have to apply DT scheme from LED common bindings and have
separate child node for each color of RGB LED.
> + };
> + };
>
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2020-03-06 20:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 13:40 [PATCH v3 0/3] leds: add support for apa102c leds Nicolas Belin
2020-03-06 13:40 ` [PATCH v3 1/3] dt-bindings: Document shiji vendor-prefix Nicolas Belin
2020-03-09 21:05 ` Rob Herring
2020-03-06 13:40 ` [PATCH v3 2/3] dt-bindings: leds: Shiji Lighting APA102C LED Nicolas Belin
2020-03-06 20:19 ` Jacek Anaszewski [this message]
2020-03-13 13:06 ` Rob Herring
2020-03-06 13:40 ` [PATCH v3 3/3] drivers: leds: add support for apa102c leds Nicolas Belin
2020-03-06 20:20 ` Jacek Anaszewski
2020-03-09 9:59 ` Nicolas Belin
2020-03-24 9:42 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70129275-087a-fd85-c771-5d72e591d190@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=baylibre-upstreaming@groups.io \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=nbelin@baylibre.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).