From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S943053AbcJ0OqK (ORCPT ); Thu, 27 Oct 2016 10:46:10 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:52280 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750780AbcJ0NsO (ORCPT ); Thu, 27 Oct 2016 09:48:14 -0400 Subject: Re: [PATCH v3] ARM: davinci: da8xx: Fix some redefined symbol warnings To: Alexandre Bailon , , References: <1477485542-10555-1-git-send-email-abailon@baylibre.com> <1477485542-10555-2-git-send-email-abailon@baylibre.com> CC: , From: Sekhar Nori Message-ID: <7026f012-ffce-cc28-85be-9a5cd26de60f@ti.com> Date: Thu, 27 Oct 2016 17:13:13 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1477485542-10555-2-git-send-email-abailon@baylibre.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 26 October 2016 06:09 PM, Alexandre Bailon wrote: > Some macro for DA8xx CFGCHIP are defined in usb-davinci.h, > but da8xx-cfgchip.h intend to replace them. > The usb-da8xx.c is using both headers, causing redefined symbol warnings. Looks like this is not true for v4.9-rc2 and so I don't see any warnings in v4.9-rc2. This is probably introduced due to some changes you are doing for v4.10 and so it is not a v4.9-rc candidate. > Remove the macro and update the board files to use da8xx-cfgchip.h This patch should probably be folded into the patch which actually introduces da8xx-cfgchip.h into usb-da8xx.c > Signed-off-by: Alexandre Bailon Thanks, Sekhar