From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E95DDC433FE for ; Fri, 28 Jan 2022 13:44:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240958AbiA1Nou (ORCPT ); Fri, 28 Jan 2022 08:44:50 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]:4545 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242206AbiA1Nor (ORCPT ); Fri, 28 Jan 2022 08:44:47 -0500 Received: from fraeml735-chm.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Jldr412C6z67Z9J; Fri, 28 Jan 2022 21:40:20 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml735-chm.china.huawei.com (10.206.15.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 28 Jan 2022 14:44:45 +0100 Received: from [10.47.26.192] (10.47.26.192) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 28 Jan 2022 13:44:44 +0000 Subject: Re: [RFC PATCH v2 1/5] perf stat: Implement --topdown with metrics To: Andrew Kilroy , , , , , CC: Mark Rutland , Alexander Shishkin , Jiri Olsa , "Namhyung Kim" References: <4fefb1bc-49b2-bc5b-23cd-cd8fabe8c588@huawei.com> <20220111150749.13365-1-andrew.kilroy@arm.com> <20220111150749.13365-2-andrew.kilroy@arm.com> From: John Garry Message-ID: <70433fdc-831e-8afa-68c3-6d75a4f8c75a@huawei.com> Date: Fri, 28 Jan 2022 13:44:08 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <20220111150749.13365-2-andrew.kilroy@arm.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.26.192] X-ClientProxiedBy: lhreml713-chm.china.huawei.com (10.201.108.64) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/01/2022 15:07, Andrew Kilroy wrote: > } > + > +bool topdown_can_use_json_metrics(void) nit: maybe topdown_can_use_metricgroups() could be better > +{ > +#if defined(__aarch64__) > + return true; > +#else > + return false; > +#endif it might be worth just having !x86, just that is prob too much forward looking > +} > +