From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Simon Horman <horms@verge.net.au>,
linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: PCI: rcar: Use common error handling code in rcar_pcie_enable_msi()
Date: Wed, 1 Nov 2017 09:57:00 +0100 [thread overview]
Message-ID: <7047eb7a-cf93-6a56-08db-a5e8bedbfc57@users.sourceforge.net> (raw)
In-Reply-To: <20171101081831.ssnuqp5b75lbfu5p@verge.net.au>
> This is fine by me
Thanks for another bit of change acceptance.
> except that the change in the name of the goto label seems spurious.
I am curious if the popularity of a jump label like “err” will decrease
(in the Linux source files) over time.
> But if you really want to change it then as it is an error path
> I should suggest it describe that its an error and what unwinding
> is done, f.e. err_remove_domain.
* Do you get such a kind of information only when the prefix “err_”
is added to this identifier?
* Do you prefer to stress the “domain removal”
(or the shown error message) in the label?
Regards,
Markus
next prev parent reply other threads:[~2017-11-01 8:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 7:35 [PATCH] PCI: rcar: Use common error handling code in rcar_pcie_enable_msi() SF Markus Elfring
2017-11-01 8:18 ` Simon Horman
2017-11-01 8:57 ` SF Markus Elfring [this message]
2017-11-02 8:12 ` Simon Horman
2017-11-02 13:00 ` [PATCH v2] " SF Markus Elfring
2017-11-02 19:25 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7047eb7a-cf93-6a56-08db-a5e8bedbfc57@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=bhelgaas@google.com \
--cc=horms@verge.net.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).