From: Nikolay Borisov <n.borisov.lkml@gmail.com>
To: Andrey Ryabinin <aryabinin@virtuozzo.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Eric Van Hensbergen <ericvh@gmail.com>,
Ron Minnich <rminnich@sandia.gov>,
Latchesar Ionkov <lucho@ionkov.net>,
Steve French <sfrench@samba.org>,
Matthew Wilcox <mawilcox@microsoft.com>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
Trond Myklebust <trond.myklebust@primarydata.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jan Kara <jack@suse.cz>, Jens Axboe <axboe@kernel.dk>,
Johannes Weiner <hannes@cmpxchg.org>,
Alexey Kuznetsov <kuznet@virtuozzo.com>,
Christoph Hellwig <hch@lst.de>,
v9fs-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org, linux-cifs@vger.kernel.org,
samba-technical@lists.samba.org, linux-nfs@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 2/4] fs/block_dev: always invalidate cleancache in invalidate_bdev()
Date: Tue, 18 Apr 2017 21:51:59 +0300 [thread overview]
Message-ID: <705067e3-eb15-ce2a-cfc8-d048dfc8be4f@gmail.com> (raw)
In-Reply-To: <20170414140753.16108-3-aryabinin@virtuozzo.com>
On 14.04.2017 17:07, Andrey Ryabinin wrote:
> invalidate_bdev() calls cleancache_invalidate_inode() iff ->nrpages != 0
> which doen't make any sense.
> Make invalidate_bdev() always invalidate cleancache data.
>
> Fixes: c515e1fd361c ("mm/fs: add hooks to support cleancache")
> Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
> ---
> fs/block_dev.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/fs/block_dev.c b/fs/block_dev.c
> index e405d8e..7af4787 100644
> --- a/fs/block_dev.c
> +++ b/fs/block_dev.c
> @@ -103,12 +103,11 @@ void invalidate_bdev(struct block_device *bdev)
> {
> struct address_space *mapping = bdev->bd_inode->i_mapping;
>
> - if (mapping->nrpages == 0)
> - return;
> -
> - invalidate_bh_lrus();
> - lru_add_drain_all(); /* make sure all lru add caches are flushed */
> - invalidate_mapping_pages(mapping, 0, -1);
> + if (mapping->nrpages) {
> + invalidate_bh_lrus();
> + lru_add_drain_all(); /* make sure all lru add caches are flushed */
> + invalidate_mapping_pages(mapping, 0, -1);
> + }
How is this different than the current code? You will only invalidate
the mapping iff ->nrpages > 0 ( I assume it can't go down below 0) ?
Perhaps just remove the if altogether?
> /* 99% of the time, we don't need to flush the cleancache on the bdev.
> * But, for the strange corners, lets be cautious
> */
>
next prev parent reply other threads:[~2017-04-18 18:52 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-14 14:07 [PATCH 0/4] Properly invalidate data in the cleancache Andrey Ryabinin
2017-04-14 14:07 ` [PATCH 1/4] fs: fix data invalidation in the cleancache during direct IO Andrey Ryabinin
2017-04-18 19:38 ` Ross Zwisler
2017-04-19 15:11 ` Andrey Ryabinin
2017-04-19 19:28 ` Ross Zwisler
2017-04-20 14:35 ` Jan Kara
2017-04-20 14:44 ` Jan Kara
2017-04-20 19:14 ` Ross Zwisler
2017-04-21 3:44 ` [PATCH 1/2] dax: prevent invalidation of mapped DAX entries Ross Zwisler
2017-04-21 3:44 ` [PATCH 2/2] dax: fix data corruption due to stale mmap reads Ross Zwisler
2017-04-25 11:10 ` Jan Kara
2017-04-25 22:59 ` Ross Zwisler
2017-04-26 8:52 ` Jan Kara
2017-04-26 22:52 ` Ross Zwisler
2017-04-27 7:26 ` Jan Kara
2017-05-01 22:38 ` Ross Zwisler
2017-05-04 9:12 ` Jan Kara
2017-05-01 22:59 ` Dan Williams
2017-04-25 10:10 ` [PATCH 1/2] dax: prevent invalidation of mapped DAX entries Jan Kara
2017-05-01 16:54 ` Ross Zwisler
2017-04-18 22:46 ` [PATCH 1/4] fs: fix data invalidation in the cleancache during direct IO Andrew Morton
2017-04-19 15:15 ` Andrey Ryabinin
2017-04-14 14:07 ` [PATCH 2/4] fs/block_dev: always invalidate cleancache in invalidate_bdev() Andrey Ryabinin
2017-04-18 18:51 ` Nikolay Borisov [this message]
2017-04-19 13:22 ` Andrey Ryabinin
2017-04-14 14:07 ` [PATCH 3/4] mm/truncate: bail out early from invalidate_inode_pages2_range() if mapping is empty Andrey Ryabinin
2017-04-14 14:07 ` [PATCH 4/4] mm/truncate: avoid pointless cleancache_invalidate_inode() calls Andrey Ryabinin
2017-04-18 15:24 ` [PATCH 0/4] Properly invalidate data in the cleancache Konrad Rzeszutek Wilk
2017-04-24 16:41 ` [PATCH v2 " Andrey Ryabinin
2017-04-24 16:41 ` [PATCH v2 1/4] fs: fix data invalidation in the cleancache during direct IO Andrey Ryabinin
2017-04-25 8:25 ` Jan Kara
2017-04-24 16:41 ` [PATCH v2 2/4] fs/block_dev: always invalidate cleancache in invalidate_bdev() Andrey Ryabinin
2017-04-25 8:34 ` Jan Kara
2017-04-24 16:41 ` [PATCH v2 3/4] mm/truncate: bail out early from invalidate_inode_pages2_range() if mapping is empty Andrey Ryabinin
2017-04-25 8:37 ` Jan Kara
2017-04-24 16:41 ` [PATCH v2 4/4] mm/truncate: avoid pointless cleancache_invalidate_inode() calls Andrey Ryabinin
2017-04-25 8:41 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=705067e3-eb15-ce2a-cfc8-d048dfc8be4f@gmail.com \
--to=n.borisov.lkml@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=anna.schumaker@netapp.com \
--cc=aryabinin@virtuozzo.com \
--cc=axboe@kernel.dk \
--cc=ericvh@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=konrad.wilk@oracle.com \
--cc=kuznet@virtuozzo.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=mawilcox@microsoft.com \
--cc=rminnich@sandia.gov \
--cc=ross.zwisler@linux.intel.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=trond.myklebust@primarydata.com \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).