From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932589AbcHaKBY (ORCPT ); Wed, 31 Aug 2016 06:01:24 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:56962 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752600AbcHaKBV (ORCPT ); Wed, 31 Aug 2016 06:01:21 -0400 From: Arnd Bergmann To: Baoyou Xie Cc: kishon@ti.com, swarren@wwwdotorg.org, thierry.reding@gmail.com, gnurou@gmail.com, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, xie.baoyou@zte.com.cn Subject: Re: [PATCH] phy: mark tegra_xusb_lane_lookup_function() static Date: Wed, 31 Aug 2016 12:01:11 +0200 Message-ID: <7060924.RuInUXIHDe@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1472634319-11886-1-git-send-email-baoyou.xie@linaro.org> References: <1472634319-11886-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:zSGDVzqxWZXei+ubpJOK0VnD/bLtk/KhLFdT9Wgf7k83zt/CIPk tclPWS3tUdy/h3mbeg+oS3fzt2oJFrHypcalDuWfCKqdXtEDfDWDeJIEvHSw/cEXvgz/Vz8 0YA/ErmoIYOH4cgHJ6j3M3oAMmVdyOSRBBMKcnWudHGVv4OwmOn8XSvUKky3M7o0A9YoqzF qxI+mMoxB68Q9AEF8+FsQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:MD54VVGSYGE=:lWhux4hEf8pSiLv0TgK9j+ xE69O4GHQG4YrMhVrjuQFoUM3WE8MwHec05F/1IgXlb3Ve5HtiMPSFjvmqO7somiwdY25YY2H mlaedAExdnBbnTIpU/hknANJHTLWW5uE/wEVjTDBrwyMI5lpPsmSEBnm1kmxyTtt4AaPVC8hV Bds6MQyijpNrTrm35Lp3sGj79jsxxj/O5kDNlzHFAc4rjD0c6ZMif4UxMP0KTbhkTEfuuxrJZ ut38avl4/S2e01E3r21oSXw27JDy6Q0oLsEBlEilAgy9CjDw5LK3k/AS10zjGH191F5ehd6nR K9BFTKq6Vmue1yki0WJ3KVLiY0ApNkn3ZSF4i15wYgl/RST6sZr17/LPUiLGmtNf8wwhZJAqL czJEzJwmhdzX4KuVQ4Wrc0jGKpI5TjvdOGzlzt7VyKBKUH1nGGqwM6kmbEKvYIWwxioo/QK0i rZ/4Nv9rsaPzFVP90VnR7RfIN7CcLkwvcGTdFMjNJXnAiMH/+BtmXPhEVox7M6LN67gdx0hi0 NnI1r5iVHHm9WiruTGvGjCRxK2ujkrh+OfYUtvoWjFVY/R2Nh7Eo1nfms0jvkMBfmyQ+X/MOU l450Tt/zWbh4i1rd8Uc2FW6WtH804DzYXRbW5CpjoqnxJuu4AxjPw2NXcREx5IqKvtvM5qlv+ pKGXui8AVkgB22X9OcuDpmQp3c+x+f9oWf7lPThmmlvr4oZBJY4SuigYLhrKNItMCdpXEAwK8 gppiwnTCRv97Bn8y Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, August 31, 2016 5:05:19 PM CEST Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/phy/tegra/xusb.c:104:5: warning: no previous prototype for 'tegra_xusb_lane_lookup_function' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is > declared and don't need a declaration, but can be made static. > So this patch marks it 'static'. > > Signed-off-by: Baoyou Xie > Acked-by: Arnd Bergmann Same comment as for the other patch, it's better to use "phy: tegra: ..." in the subject for clarity. Arnd