From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
To: unlisted-recipients:; (no To-header on input)
Cc: thierry.reding@gmail.com, sam@ravnborg.org, airlied@linux.ie,
daniel@ffwll.ch, robh+dt@kernel.org,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Quentin Schulz <foss+kernel@0leil.net>
Subject: Re: [PATCH 1/3] drm/panel: ltk050h3146w: add mipi_dsi_device.mode_flags to of_match_data
Date: Tue, 3 May 2022 17:23:21 +0200 [thread overview]
Message-ID: <7091bd70-d7d1-8e88-d0d9-22ec944ff9df@theobroma-systems.com> (raw)
In-Reply-To: <20220131164723.714836-1-quentin.schulz@theobroma-systems.com>
Hi all,
Seems I'm not the only one who forgot about this patch series, so,
kindly pinging :)
Thanks!
Quentin
On 1/31/22 17:47, quentin.schulz@theobroma-systems.com wrote:
> From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
>
> To prepare for a new display to be supported by this driver which has a
> slightly different set of DSI mode related flags, let's move the
> currently hardcoded mode flags to the .data field of of_device_id
> structure.
>
> Cc: Quentin Schulz <foss+kernel@0leil.net>
> Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
> ---
> drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c
> index a5a414920430..67eb474e28c6 100644
> --- a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c
> +++ b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c
> @@ -25,6 +25,7 @@ struct ltk050h3146w_cmd {
>
> struct ltk050h3146w;
> struct ltk050h3146w_desc {
> + const unsigned long mode_flags;
> const struct drm_display_mode *mode;
> int (*init)(struct ltk050h3146w *ctx);
> };
> @@ -339,6 +340,8 @@ static const struct drm_display_mode ltk050h3146w_mode = {
> static const struct ltk050h3146w_desc ltk050h3146w_data = {
> .mode = <k050h3146w_mode,
> .init = ltk050h3146w_init_sequence,
> + .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |
> + MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_NO_EOT_PACKET,
> };
>
> static int ltk050h3146w_a2_select_page(struct ltk050h3146w *ctx, int page)
> @@ -433,6 +436,8 @@ static const struct drm_display_mode ltk050h3146w_a2_mode = {
> static const struct ltk050h3146w_desc ltk050h3146w_a2_data = {
> .mode = <k050h3146w_a2_mode,
> .init = ltk050h3146w_a2_init_sequence,
> + .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |
> + MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_NO_EOT_PACKET,
> };
>
> static int ltk050h3146w_unprepare(struct drm_panel *panel)
> @@ -592,8 +597,7 @@ static int ltk050h3146w_probe(struct mipi_dsi_device *dsi)
>
> dsi->lanes = 4;
> dsi->format = MIPI_DSI_FMT_RGB888;
> - dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |
> - MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_NO_EOT_PACKET;
> + dsi->mode_flags = ctx->panel_desc->mode_flags;
>
> drm_panel_init(&ctx->panel, &dsi->dev, <k050h3146w_funcs,
> DRM_MODE_CONNECTOR_DSI);
next prev parent reply other threads:[~2022-05-03 15:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 16:47 [PATCH 1/3] drm/panel: ltk050h3146w: add mipi_dsi_device.mode_flags to of_match_data quentin.schulz
2022-01-31 16:47 ` [PATCH 2/3] drm/panel: ltk050h3146w: add support for Leadtek LTK050H3148W-CTA6 variant quentin.schulz
2022-06-09 8:51 ` Paul Kocialkowski
2022-01-31 16:47 ` [PATCH 3/3] dt-bindings: ltk050h3146w: add compatible for " quentin.schulz
2022-02-11 13:30 ` Rob Herring
2022-06-09 8:52 ` Paul Kocialkowski
2022-05-03 15:23 ` Quentin Schulz [this message]
2022-06-09 8:50 ` [PATCH 1/3] drm/panel: ltk050h3146w: add mipi_dsi_device.mode_flags to of_match_data Paul Kocialkowski
2023-10-10 16:54 ` Heiko Stuebner
2023-10-10 16:55 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7091bd70-d7d1-8e88-d0d9-22ec944ff9df@theobroma-systems.com \
--to=quentin.schulz@theobroma-systems.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=foss+kernel@0leil.net \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).