From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D4CBCA9EB9 for ; Tue, 22 Oct 2019 13:42:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 734D421906 for ; Tue, 22 Oct 2019 13:42:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=st.com header.i=@st.com header.b="lpZh7ZFe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388831AbfJVNmD (ORCPT ); Tue, 22 Oct 2019 09:42:03 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:43764 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388176AbfJVNmD (ORCPT ); Tue, 22 Oct 2019 09:42:03 -0400 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x9MDfKcR013037; Tue, 22 Oct 2019 15:41:50 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=STMicroelectronics; bh=6OiFUl1fdaeRq1DoqLpiVMazeaoQpnE/nLtSGyzhd/8=; b=lpZh7ZFe5rXJeK1A8+nZpUxIAl5J+lyHSBolGt5yILdDdCixYyq0pd75X4DHt5qw4iN6 Chhy29zxH9wMp5nLYqg5X0Ww9SS4s/n1uZmnzN1jToNgKBMQ+/BqpK+sA7OTfgraKDJ1 EkESAXyPc64j9G8WxNAC4qz1xjqLBKlsot1KbBJ3kcEffBg6as2XW6HB0aOLkymTtF50 U1TjOid7B2eWC8OQO/cVGRICKfvuuL+DuXXydzPOFe2BDYCqh4EI1/O5kKBpyouROIyI Zzb2YWpKOBD8XLYWe1r2fnugylUGykNsBjGxdiT6XNV5O8/OXyuEz2f7/etuXGkSMu+N Ew== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 2vqqy17uyd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 22 Oct 2019 15:41:50 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 6E57310002A; Tue, 22 Oct 2019 15:41:50 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag5node2.st.com [10.75.127.14]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 5C9BB2AE210; Tue, 22 Oct 2019 15:41:50 +0200 (CEST) Received: from [10.48.1.171] (10.75.127.51) by SFHDAG5NODE2.st.com (10.75.127.14) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 22 Oct 2019 15:41:49 +0200 Subject: Re: [PATCH] i2c: i2c-stm32f7: rework slave_id allocation To: Alain Volmat , , CC: , , , , , , , , References: <1571144589-3066-1-git-send-email-alain.volmat@st.com> From: Pierre Yves MORDRET Message-ID: <7092a0d6-2f6a-fa1f-2999-17418b479c5f@st.com> Date: Tue, 22 Oct 2019 15:41:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <1571144589-3066-1-git-send-email-alain.volmat@st.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.51] X-ClientProxiedBy: SFHDAG5NODE2.st.com (10.75.127.14) To SFHDAG5NODE2.st.com (10.75.127.14) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-10-22_03:2019-10-22,2019-10-22 signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Looks good Reviewed-by: Pierre-Yves MORDRET Thx Regards On 10/15/19 3:03 PM, Alain Volmat wrote: > The IP can handle two slave addresses. One address can either be > 7 bits or 10 bits while the other can only be 7 bits. > In order to ensure that a 10 bits address can always be allocated > (assuming there is only one 7 bits address already allocated), > pick up the 7-bits only address slot in priority when performing a 7-bits > address allocation. > > Fixes: 60d609f3 ("i2c: i2c-stm32f7: Add slave support") > > Signed-off-by: Alain Volmat > --- > drivers/i2c/busses/i2c-stm32f7.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c > index d36cf08461f7..cfae01b15243 100644 > --- a/drivers/i2c/busses/i2c-stm32f7.c > +++ b/drivers/i2c/busses/i2c-stm32f7.c > @@ -1265,7 +1265,7 @@ static int stm32f7_i2c_get_free_slave_id(struct stm32f7_i2c_dev *i2c_dev, > * slave[0] supports 7-bit and 10-bit slave address > * slave[1] supports 7-bit slave address only > */ > - for (i = 0; i < STM32F7_I2C_MAX_SLAVE; i++) { > + for (i = STM32F7_I2C_MAX_SLAVE - 1; i >= 0; i--) { > if (i == 1 && (slave->flags & I2C_CLIENT_PEC)) > continue; > if (!i2c_dev->slave[i]) { >