From: "Błażej Szczygieł" <spaz16@wp.pl>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: igorkuo@gmail.com, Jiri Kosina <jikos@kernel.org>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] HID: fix A4Tech horizontal scrolling
Date: Fri, 3 May 2019 11:22:12 +0200 [thread overview]
Message-ID: <70982912-b172-b5dd-a875-fd0e7b378430@wp.pl> (raw)
In-Reply-To: <CAO-hwJLbFv3S9M5N+BKBuafj8H-vToy=2VQd=cvohmaTHLMC3A@mail.gmail.com>
Hi,
I used the hid-record tool and my results are here:
https://gitlab.com/snippets/1853568
Cheers,
Błażej
> Hi,
>
> On Thu, May 2, 2019 at 11:37 PM Błażej Szczygieł <spaz16@wp.pl> wrote:
>>
>> Since recent high resolution scrolling changes the A4Tech driver must
>> check for the "REL_WHEEL_HI_RES" usage code.
>>
>> Fixes: 2dc702c991e3774af9d7ce410eef410ca9e2357e (HID: input: use the
>> Resolution Multiplier for high-resolution scrolling)
>>
>> Signed-off-by: Błażej Szczygieł <spaz16@wp.pl>
>
> Thanks for the patch. I do not doubt this fixes the issues, but I
> still wonder if we should not export REL_HWHEEL_HI_RES instead of
> REL_HWHEEL events.
>
> Also, I can not figure out how the events are processed by the kernel.
> Could you attach a hid-recorder dump of the mouse wheels with
> hid-recorder from https://gitlab.freedesktop.org/libevdev/hid-tools ?
>
> This should give me a better view of the mouse, and I could also add
> it to the regression tests I am running for each commit.
>
> Cheers,
> Benjamin
>
>> ---
>> drivers/hid/hid-a4tech.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/hid/hid-a4tech.c b/drivers/hid/hid-a4tech.c
>> index 9428ea7cdf8a..fafb9fa558e7 100644
>> --- a/drivers/hid/hid-a4tech.c
>> +++ b/drivers/hid/hid-a4tech.c
>> @@ -38,7 +38,7 @@ static int a4_input_mapped(struct hid_device *hdev, struct hid_input *hi,
>> {
>> struct a4tech_sc *a4 = hid_get_drvdata(hdev);
>>
>> - if (usage->type == EV_REL && usage->code == REL_WHEEL)
>> + if (usage->type == EV_REL && usage->code == REL_WHEEL_HI_RES)
>> set_bit(REL_HWHEEL, *bit);
>>
>> if ((a4->quirks & A4_2WHEEL_MOUSE_HACK_7) && usage->hid == 0x00090007)
>> @@ -60,7 +60,7 @@ static int a4_event(struct hid_device *hdev, struct hid_field *field,
>> input = field->hidinput->input;
>>
>> if (a4->quirks & A4_2WHEEL_MOUSE_HACK_B8) {
>> - if (usage->type == EV_REL && usage->code == REL_WHEEL) {
>> + if (usage->type == EV_REL && usage->code == REL_WHEEL_HI_RES) {
>> a4->delayed_value = value;
>> return 1;
>> }
>> @@ -77,7 +77,7 @@ static int a4_event(struct hid_device *hdev, struct hid_field *field,
>> return 1;
>> }
>>
>> - if (usage->code == REL_WHEEL && a4->hw_wheel) {
>> + if (usage->code == REL_WHEEL_HI_RES && a4->hw_wheel) {
>> input_event(input, usage->type, REL_HWHEEL, value);
>> return 1;
>> }
>> --
>> 2.21.0
>>
next prev parent reply other threads:[~2019-05-03 9:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 21:36 [PATCH] HID: fix A4Tech horizontal scrolling Błażej Szczygieł
2019-05-03 7:36 ` Benjamin Tissoires
2019-05-03 9:22 ` Błażej Szczygieł [this message]
2019-05-03 9:36 ` Igor Kushnir
2019-05-03 11:59 ` Benjamin Tissoires
2019-05-07 5:01 ` Peter Hutterer
2019-05-12 20:59 ` Błażej Szczygieł
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70982912-b172-b5dd-a875-fd0e7b378430@wp.pl \
--to=spaz16@wp.pl \
--cc=benjamin.tissoires@redhat.com \
--cc=igorkuo@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).