linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Song, Youquan" <youquan.song@intel.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
	"Rafael J. Wysocki" <rjw@sisk.pl>
Cc: "linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Rik van Riel <riel@redhat.com>,
	"Song, Youquan" <youquan.song@intel.com>,
	"Wu, Fengguang" <fengguang.wu@intel.com>
Subject: RE: linux-next: build failure after merge of the final tree (pm tree related)
Date: Wed, 24 Oct 2012 03:58:00 +0000	[thread overview]
Message-ID: <70A3B115BE79814398B8E4E7C4AE18EE13A218@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20121024144400.f5779e119f248256aa183ef5@canb.auug.org.au>

Yes. We already do the patch to fix the warning yesterday after get the information from Fengguang's "0-DAY kernel build testing".  But do not refresh linux-next so quickly.
Thanks for the information and patch, Stephen!

-Youquan

-----Original Message-----
From: Stephen Rothwell [mailto:sfr@canb.auug.org.au] 
Sent: Wednesday, October 24, 2012 11:44 AM
To: Rafael J. Wysocki
Cc: linux-next@vger.kernel.org; linux-kernel@vger.kernel.org; Song, Youquan; Rik van Riel
Subject: linux-next: build failure after merge of the final tree (pm tree related)

Hi all,

After merging the final tree, today's linux-next build (powerpc
allnoconfig) failed like this:

In file included from arch/powerpc/kernel/idle.c:27:0:
include/linux/tick.h: In function 'menu_hrtimer_cancel':
include/linux/tick.h:148:48: error: 'return' with a value, in function returning void [-Werror]

Several of these :-(

Caused by commit 25d77b76d7ae ("cpuidle: Quickly notice prediction failure for repeat mode") from the pm tree.  This build has CONFIG_CPU_IDLE_GOV_MENU turned off.  For changes that are obviously affected by CONFIG options, please test build with the CONFIG option on and off.

I have applied the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 24 Oct 2012 14:40:47 +1100
Subject: [PATCH] cpuidle: fix up but return type for inline function

Fixes this error when CONFIG_CPU_IDLE_GOV_MENU is not enabled:

In file included from arch/powerpc/kernel/idle.c:27:0:
include/linux/tick.h: In function 'menu_hrtimer_cancel':
include/linux/tick.h:148:48: error: 'return' with a value, in function returning void [-Werror]

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/linux/tick.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/tick.h b/include/linux/tick.h index 8867424..40d123e 100644
--- a/include/linux/tick.h
+++ b/include/linux/tick.h
@@ -145,7 +145,7 @@ static inline u64 get_cpu_iowait_time_us(int cpu, u64 *unused) { return -1; }  # ifdef CONFIG_CPU_IDLE_GOV_MENU  extern void menu_hrtimer_cancel(void);  # else -static inline void menu_hrtimer_cancel(void) { return -1; }
+static inline void menu_hrtimer_cancel(void) { }
 # endif /* CONFIG_CPU_IDLE_GOV_MENU */
 
 #endif
--
1.7.10.280.gaa39

--
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

  reply	other threads:[~2012-10-24  3:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-24  3:44 linux-next: build failure after merge of the final tree (pm tree related) Stephen Rothwell
2012-10-24  3:58 ` Song, Youquan [this message]
2012-10-24 21:40 ` Rafael J. Wysocki
  -- strict thread matches above, loose matches on Subject: below --
2011-12-22  5:28 Stephen Rothwell
2011-12-23  0:32 ` Rafael J. Wysocki
2011-11-14  3:24 Stephen Rothwell
2011-11-14 23:12 ` Rafael J. Wysocki
2011-11-24  6:19   ` Stephen Rothwell
2011-11-24  6:32     ` Tejun Heo
2011-11-24 10:15       ` Rafael J. Wysocki
2011-08-19  3:03 Stephen Rothwell
2011-08-19  8:14 ` Pihet-XID, Jean
2011-08-19 13:39   ` Stephen Rothwell
2011-08-19 20:33     ` Randy Dunlap
2011-08-19 21:58   ` Rafael J. Wysocki
2011-08-20  7:50     ` Pihet-XID, Jean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=70A3B115BE79814398B8E4E7C4AE18EE13A218@SHSMSX101.ccr.corp.intel.com \
    --to=youquan.song@intel.com \
    --cc=fengguang.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=riel@redhat.com \
    --cc=rjw@sisk.pl \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).