From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752236AbdBCUSu (ORCPT ); Fri, 3 Feb 2017 15:18:50 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:49662 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752156AbdBCUSr (ORCPT ); Fri, 3 Feb 2017 15:18:47 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org F0EF76080D Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=tbaicar@codeaurora.org Subject: Re: [PATCH V8 09/10] trace, ras: add ARM processor error trace event To: Steven Rostedt References: <1485969413-23577-1-git-send-email-tbaicar@codeaurora.org> <1485969413-23577-10-git-send-email-tbaicar@codeaurora.org> <20170201221544.3d8651e5@grimm.local.home> Cc: christoffer.dall@linaro.org, marc.zyngier@arm.com, pbonzini@redhat.com, rkrcmar@redhat.com, linux@armlinux.org.uk, catalin.marinas@arm.com, will.deacon@arm.com, rjw@rjwysocki.net, lenb@kernel.org, matt@codeblueprint.co.uk, robert.moore@intel.com, lv.zheng@intel.com, nkaje@codeaurora.org, zjzhang@codeaurora.org, mark.rutland@arm.com, james.morse@arm.com, akpm@linux-foundation.org, eun.taik.lee@samsung.com, sandeepa.s.prabhu@gmail.com, labbott@redhat.com, shijie.huang@arm.com, rruigrok@codeaurora.org, paul.gortmaker@windriver.com, tn@semihalf.com, fu.wei@linaro.org, bristot@redhat.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-efi@vger.kernel.org, devel@acpica.org, Suzuki.Poulose@arm.com, punit.agrawal@arm.com, astone@redhat.com, harba@codeaurora.org, hanjun.guo@linaro.org, john.garry@huawei.com, shiju.jose@huawei.com From: "Baicar, Tyler" Message-ID: <70bd0d57-4369-ac7d-10c6-2c9de62a666f@codeaurora.org> Date: Fri, 3 Feb 2017 13:18:40 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170201221544.3d8651e5@grimm.local.home> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Steve, On 2/1/2017 8:15 PM, Steven Rostedt wrote: > On Wed, 1 Feb 2017 10:16:52 -0700 > Tyler Baicar wrote: > >> Currently there are trace events for the various RAS >> errors with the exception of ARM processor type errors. >> Add a new trace event for such errors so that the user >> will know when they occur. These trace events are >> consistent with the ARM processor error section type >> defined in UEFI 2.6 spec section N.2.4.4. >> >> Signed-off-by: Tyler Baicar >> Acked-by: Steven Rostedt >> --- >> drivers/acpi/apei/ghes.c | 7 ++++++- >> drivers/firmware/efi/cper.c | 1 + >> drivers/ras/ras.c | 1 + >> include/ras/ras_event.h | 34 ++++++++++++++++++++++++++++++++++ >> 4 files changed, 42 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c >> index a989345..013faf0 100644 >> --- a/drivers/acpi/apei/ghes.c >> +++ b/drivers/acpi/apei/ghes.c >> @@ -512,7 +512,12 @@ static void ghes_do_proc(struct ghes *ghes, >> >> } >> #endif >> - else { >> + else if (!uuid_le_cmp(sec_type, CPER_SEC_PROC_ARM)) { >> + struct cper_sec_proc_arm *arm_err; >> + >> + arm_err = acpi_hest_generic_data_payload(gdata); >> + trace_arm_event(arm_err); > According to the kbuild failure, I'm guessing this file requires a: > > #include I add that include in patch 8/10 of this series, so ghes.c has the include before this patch. The kbuild complained about the same thing for both trace events added in this series. Upon further debug, it looks like I'll need to verify that CONFIG_RAS is enabled to make these trace event calls. It's strange that kbuild didn't complain in earlier versions of this series because these have been this way the whole time :) I'll add the config check in the next series. Thanks, Tyler > -- Steve > >> + } else { >> void *unknown_err = acpi_hest_generic_data_payload(gdata); >> trace_unknown_sec_event(&sec_type, >> fru_id, fru_text, sec_sev, >> diff --git a/drivers/firmware/efi/cper.c b/drivers/firmware/efi/cper.c >> index 48cb8ee..0ec678e 100644 >> --- a/drivers/firmware/efi/cper.c >> +++ b/drivers/firmware/efi/cper.c >> @@ -35,6 +35,7 @@ >> #include >> #include >> #include >> +#include >> >> #define INDENT_SP " " >> >> diff --git a/drivers/ras/ras.c b/drivers/ras/ras.c >> index fb2500b..8ba5a94 100644 >> --- a/drivers/ras/ras.c >> +++ b/drivers/ras/ras.c >> @@ -28,3 +28,4 @@ static int __init ras_init(void) >> #endif >> EXPORT_TRACEPOINT_SYMBOL_GPL(mc_event); >> EXPORT_TRACEPOINT_SYMBOL_GPL(unknown_sec_event); >> +EXPORT_TRACEPOINT_SYMBOL_GPL(arm_event); >> diff --git a/include/ras/ras_event.h b/include/ras/ras_event.h >> index 5861b6f..b36db48 100644 >> --- a/include/ras/ras_event.h >> +++ b/include/ras/ras_event.h >> @@ -162,6 +162,40 @@ >> ); >> >> /* >> + * ARM Processor Events Report >> + * >> + * This event is generated when hardware detects an ARM processor error >> + * has occurred. UEFI 2.6 spec section N.2.4.4. >> + */ >> +TRACE_EVENT(arm_event, >> + >> + TP_PROTO(const struct cper_sec_proc_arm *proc), >> + >> + TP_ARGS(proc), >> + >> + TP_STRUCT__entry( >> + __field(u64, mpidr) >> + __field(u64, midr) >> + __field(u32, running_state) >> + __field(u32, psci_state) >> + __field(u8, affinity) >> + ), >> + >> + TP_fast_assign( >> + __entry->affinity = proc->affinity_level; >> + __entry->mpidr = proc->mpidr; >> + __entry->midr = proc->midr; >> + __entry->running_state = proc->running_state; >> + __entry->psci_state = proc->psci_state; >> + ), >> + >> + TP_printk("affinity level: %d; MPIDR: %016llx; MIDR: %016llx; " >> + "running state: %d; PSCI state: %d", >> + __entry->affinity, __entry->mpidr, __entry->midr, >> + __entry->running_state, __entry->psci_state) >> +); >> + >> +/* >> * Unknown Section Report >> * >> * This event is generated when hardware detected a hardware -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.