From: Paolo Bonzini <pbonzini@redhat.com>
To: "joro@8bytes.org" <joro@8bytes.org>,
"Suthikulpanit, Suravee" <Suravee.Suthikulpanit@amd.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"rkrcmar@redhat.com" <rkrcmar@redhat.com>,
Wei Wang <wawei@amazon.de>, Amadeusz Juskowiak <ajusk@amazon.de>,
Julian Stecklina <jsteckli@amazon.de>
Subject: Re: [PATCH] svm: Add mutex_lock to protect apic_access_page_done on AMD systems
Date: Sun, 25 Nov 2018 18:34:41 +0100 [thread overview]
Message-ID: <70cc4362-5a95-d6ec-fccf-4cbe3b03bdc9@redhat.com> (raw)
In-Reply-To: <20181112133731.lwje2hzibd64cvc3@8bytes.org>
On 12/11/18 14:37, joro@8bytes.org wrote:
> On Mon, Nov 12, 2018 at 12:23:14PM +0000, Suthikulpanit, Suravee wrote:
>> From: Wei Wang <wawei@amazon.de>
>>
>> There is a race condition when accessing kvm->arch.apic_access_page_done.
>> Due to it, x86_set_memory_region will fail when creating the second vcpu
>> for a svm guest.
>>
>> Add a mutex_lock to serialize the accesses to apic_access_page_done.
>> This lock is also used by vmx for the same purpose.
>>
>> Signed-off-by: Wei Wang <wawei@amazon.de>
>> Signed-off-by: Amadeusz Juskowiak <ajusk@amazon.de>
>> Signed-off-by: Julian Stecklina <jsteckli@amazon.de>
>> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> Reviewed-by: Joerg Roedel <jroedel@suse.de>
Queued, thanks.
Paolo
prev parent reply other threads:[~2018-11-25 17:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 12:23 [PATCH] svm: Add mutex_lock to protect apic_access_page_done on AMD systems Suthikulpanit, Suravee
2018-11-12 13:37 ` joro
2018-11-25 17:34 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70cc4362-5a95-d6ec-fccf-4cbe3b03bdc9@redhat.com \
--to=pbonzini@redhat.com \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=ajusk@amazon.de \
--cc=joro@8bytes.org \
--cc=jsteckli@amazon.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkrcmar@redhat.com \
--cc=wawei@amazon.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).