From: Paolo Bonzini <pbonzini@redhat.com>
To: Bandan Das <bsd@redhat.com>
Cc: kvm@vger.kernel.org, guangrong.xiao@linux.intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] mmu: mark spte present if the x bit is set
Date: Tue, 28 Jun 2016 22:49:17 +0200 [thread overview]
Message-ID: <70de38d1-2743-09dd-dc47-6242799a701c@redhat.com> (raw)
In-Reply-To: <jpg37nxrqvs.fsf@linux.bootlegged.copy>
On 28/06/2016 22:37, Bandan Das wrote:
> Paolo Bonzini <pbonzini@redhat.com> writes:
>
>> On 28/06/2016 19:33, Bandan Das wrote:
>>>>>>> static int is_shadow_present_pte(u64 pte)
>>>>>>> {
>>>>>>> - return pte & PT_PRESENT_MASK && !is_mmio_spte(pte);
>>>>>>> + return pte & (PT_PRESENT_MASK | shadow_x_mask) &&
>>>>>>> + !is_mmio_spte(pte);
>>>>>
>>>>> This should really be pte & 7 when using EPT. But this is okay as an
>>>>> alternative to a new shadow_present_mask.
>>> I could revive shadow_xonly_valid probably... Anyway, for now I will
>>> add a TODO comment here.
>>
>> It's okay to it like this, because the only invalid PTEs reaching this
>> point are those that is_mmio_spte filters away. Hence you'll never get
>> -W- PTEs here, and pte & 7 is really the same as how you wrote it. It's
>> pretty clever, and doesn't need a TODO at all. :)
>
> Thanks, understood. So, the way it is written now covers all cases for
> pte & 7. Let's still add a comment - clever things are usually
> confusing to many!
I think another way to write it is "(pte & 0xFFFFFFFFull) &&
!is_mmio_spte(pte)", since non-present/non-MMIO SPTEs never use bits
1..31 (they can have non-zero bits 32..63 on 32-bit CPUs where we don't
update the PTEs atomically). Guangrong, what do you prefer?
Paolo
next prev parent reply other threads:[~2016-06-28 20:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 4:32 [PATCH 0/5] Add support for EPT execute only for nested hypervisors Bandan Das
2016-06-28 4:32 ` [PATCH 1/5] mmu: mark spte present if the x bit is set Bandan Das
2016-06-28 8:44 ` Paolo Bonzini
2016-06-28 17:33 ` Bandan Das
2016-06-28 20:17 ` Paolo Bonzini
2016-06-28 20:37 ` Bandan Das
2016-06-28 20:49 ` Paolo Bonzini [this message]
2016-06-28 21:04 ` Bandan Das
2016-06-29 3:01 ` Xiao Guangrong
2016-07-05 3:06 ` Wanpeng Li
2016-07-05 10:50 ` Paolo Bonzini
2016-07-05 11:29 ` Wanpeng Li
2016-06-28 4:32 ` [PATCH 2/5] mmu: pass execonly value when initializing rsvd bits Bandan Das
2016-06-29 3:07 ` Xiao Guangrong
2016-06-28 4:32 ` [PATCH 3/5] mmu: don't set the present bit unconditionally Bandan Das
2016-06-28 8:57 ` Paolo Bonzini
2016-06-28 17:30 ` Bandan Das
2016-06-28 20:21 ` Paolo Bonzini
2016-07-05 5:50 ` Wanpeng Li
2016-07-05 10:50 ` Paolo Bonzini
2016-06-29 3:17 ` Xiao Guangrong
2016-06-29 8:18 ` Paolo Bonzini
2016-06-30 7:18 ` Xiao Guangrong
2016-06-28 4:32 ` [PATCH 4/5] mmu: remove is_present_gpte() Bandan Das
2016-06-28 4:32 ` [PATCH 5/5] nvmx: advertise support for ept execute only Bandan Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70de38d1-2743-09dd-dc47-6242799a701c@redhat.com \
--to=pbonzini@redhat.com \
--cc=bsd@redhat.com \
--cc=guangrong.xiao@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).