From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-24.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 747CBC433E9 for ; Wed, 24 Feb 2021 01:58:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3BAB164E85 for ; Wed, 24 Feb 2021 01:58:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232297AbhBXB6W (ORCPT ); Tue, 23 Feb 2021 20:58:22 -0500 Received: from linux.microsoft.com ([13.77.154.182]:32904 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229791AbhBXB6T (ORCPT ); Tue, 23 Feb 2021 20:58:19 -0500 Received: from [192.168.0.104] (c-73-42-176-67.hsd1.wa.comcast.net [73.42.176.67]) by linux.microsoft.com (Postfix) with ESMTPSA id 892BA20B6C40; Tue, 23 Feb 2021 17:57:37 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 892BA20B6C40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1614131858; bh=CNeMw241KcxyH0UAcQxqFz1OLixiG1YC+76tEinbl/E=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=GJ+7PxBqW3sVo/IP9/j2K6+Xlq1vNtLWiZTaXGNjvlEw/JDbWhxxdBRa7tLwVsH7S P1x/Uwz2bpke2Y4C8kjt3GCPxe2WUDxAId6KLgJQYQGdy7Rt2uBhlqiikaJcDCTf+J H9ExNZnRI4mIzR/eWi2w4C27Hb3AnKL6f+0qvOm0= Subject: Re: [PATCH v19 05/13] of: Add a common kexec FDT setup function To: Thiago Jung Bauermann Cc: zohar@linux.ibm.com, robh@kernel.org, takahiro.akashi@linaro.org, gregkh@linuxfoundation.org, will@kernel.org, joe@perches.com, catalin.marinas@arm.com, mpe@ellerman.id.au, sfr@canb.auug.org.au, james.morse@arm.com, sashal@kernel.org, benh@kernel.crashing.org, paulus@samba.org, frowand.list@gmail.com, vincenzo.frascino@arm.com, mark.rutland@arm.com, dmitry.kasatkin@gmail.com, jmorris@namei.org, serge@hallyn.com, pasha.tatashin@soleen.com, allison@lohutok.net, masahiroy@kernel.org, mbrugger@suse.com, hsinyi@chromium.org, tao.li@vivo.com, christophe.leroy@c-s.fr, prsriva@linux.microsoft.com, balajib@linux.microsoft.com, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org References: <20210221174930.27324-1-nramas@linux.microsoft.com> <20210221174930.27324-6-nramas@linux.microsoft.com> <874ki2w9ak.fsf@manicouagan.localdomain> From: Lakshmi Ramasubramanian Message-ID: <70ee14f5-12ee-f33d-a6ea-b890d390d67c@linux.microsoft.com> Date: Tue, 23 Feb 2021 17:57:36 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <874ki2w9ak.fsf@manicouagan.localdomain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/23/21 5:20 PM, Thiago Jung Bauermann wrote: > > Lakshmi Ramasubramanian writes: > >> From: Rob Herring >> >> Both arm64 and powerpc do essentially the same FDT /chosen setup for >> kexec. The differences are either omissions that arm64 should have >> or additional properties that will be ignored. The setup code can be >> combined and shared by both powerpc and arm64. >> >> The differences relative to the arm64 version: >> - If /chosen doesn't exist, it will be created (should never happen). >> - Any old dtb and initrd reserved memory will be released. >> - The new initrd and elfcorehdr are marked reserved. >> - "linux,booted-from-kexec" is set. >> >> The differences relative to the powerpc version: >> - "kaslr-seed" and "rng-seed" may be set. >> - "linux,elfcorehdr" is set. >> - Any existing "linux,usable-memory-range" is removed. >> >> Combine the code for setting up the /chosen node in the FDT and updating >> the memory reservation for kexec, for powerpc and arm64, in >> of_kexec_alloc_and_setup_fdt() and move it to "drivers/of/kexec.c". >> >> Signed-off-by: Rob Herring >> Signed-off-by: Lakshmi Ramasubramanian >> Fixes: 33488dc4d61f ("of: Add a common kexec FDT setup function") > > A patch cannot fix itself. The world would be a much better place if it > could. :-) :) > >> Reported-by: kernel test robot >> --- >> drivers/of/Makefile | 6 + >> drivers/of/kexec.c | 265 ++++++++++++++++++++++++++++++++++++++++++++ >> include/linux/of.h | 5 + >> 3 files changed, 276 insertions(+) >> create mode 100644 drivers/of/kexec.c > > With that fixed: > > Reviewed-by: Thiago Jung Bauermann Thanks for reviewing the patches Thiago. -lakshmi