From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04558C433B4 for ; Wed, 14 Apr 2021 08:14:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DEF3961222 for ; Wed, 14 Apr 2021 08:14:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349974AbhDNIPD (ORCPT ); Wed, 14 Apr 2021 04:15:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349965AbhDNIPA (ORCPT ); Wed, 14 Apr 2021 04:15:00 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A530C061756 for ; Wed, 14 Apr 2021 01:14:39 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id x7so18929354wrw.10 for ; Wed, 14 Apr 2021 01:14:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AzOeHUL5hWREqhzcyblXs0nwBc2sByyKR9pZRnAp0AI=; b=0FmOSwJTluFKGhZXB4mnmPu/678q4lQVbHX5xKkleebC4yuu2Roe12fLkCO4z4yT0w 9zQnJRSNRxWV7DsOe/mDJfw6sCW6yvcK5nYcIaYEikqylBLKWTu9WezbOY6XfpeUvmGk ijGprdgw8ZPAAa3PNPNMzFtK3LmpzC8QnGoQTVjxDFD+9Kfh8pGdZu2HqsG7FU0xK3Az ADi19P7BqgzRRJRkrTO9rUEiO/VFiUTfRPduRqqoK6zKyUtDPFEZjmgWKod/zNgNXhOm C6vAj/2HUQp4/3ro+DWNtg1dL2U35wOqw1bPMFoaSwWDKqdqC2RTXXD/w0fy6+iKziKk TWUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=AzOeHUL5hWREqhzcyblXs0nwBc2sByyKR9pZRnAp0AI=; b=DK2GSrgEciguHAop4zC3VkzxJ+ogmF8KPIn/wHyTpNQfXgWT1cJJ+jXbqMnN4FYR33 jLp8o829Z5Y69s0yMzbvouFQ+faM1whwNiRb/ZiyOmmNb2BmmBeqFK1vD1FgbKbjvpe0 nik1Adn/y6lWn8tAezJpodwrnK3zGlPToelXMp/pGffR024BF6Ytsk448PuTgz1p7y6x DKA3DZ8tYbkiNgDiqL+5bjOVbTVp9qqTBE/2mYDTwEXsUrVL8ZtKl6LZU9+KWE8jFok2 mK/iGbDJtC43x++y90bNZuLPfgrItTQr8mFhnDfpclC7PXaPkZpXY2QEo1mEKNMh9fUP hL5g== X-Gm-Message-State: AOAM533N7ZCbaCXuzL8cL2HRdFlpnfWYHgAefM0hJRO9takkXdwfeBut UHjyLUXWy+bUEGNe+4D03nFudvT1ZpMBcXVe X-Google-Smtp-Source: ABdhPJzv2P3PwzGpjC5Oyj4tupZbVhAGn5ScmnavLeXSMF+c6aZxXfPaA4hgLXQ1YSsw26NNBLO+hw== X-Received: by 2002:a05:6000:1091:: with SMTP id y17mr14291716wrw.270.1618388077948; Wed, 14 Apr 2021 01:14:37 -0700 (PDT) Received: from ?IPv6:2a01:e0a:90c:e290:49d:95f:49d5:fff7? ([2a01:e0a:90c:e290:49d:95f:49d5:fff7]) by smtp.gmail.com with ESMTPSA id d5sm27606092wrx.0.2021.04.14.01.14.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Apr 2021 01:14:37 -0700 (PDT) Subject: Re: [PATCH v3 1/3] dt-bindings: display: bridge: add it66121 bindings To: Laurent Pinchart Cc: a.hajda@samsung.com, paul@crapouillou.net, robert.foss@linaro.org, devicetree@vger.kernel.org, jonas@kwiboo.se, jernej.skrabec@siol.net, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Phong LE References: <20210412154648.3719153-1-narmstrong@baylibre.com> <20210412154648.3719153-2-narmstrong@baylibre.com> From: Neil Armstrong Organization: Baylibre Message-ID: <7111ccdf-ff64-f959-a652-623fa89ffe87@baylibre.com> Date: Wed, 14 Apr 2021 10:14:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/04/2021 18:03, Laurent Pinchart wrote: > Hi Neil, > > Thank you for the patch. > > On Mon, Apr 12, 2021 at 05:46:46PM +0200, Neil Armstrong wrote: >> From: Phong LE >> >> Add the ITE bridge HDMI it66121 bindings. >> >> Signed-off-by: Phong LE >> Signed-off-by: Neil Armstrong >> --- >> .../bindings/display/bridge/ite,it66121.yaml | 123 ++++++++++++++++++ >> 1 file changed, 123 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml >> >> diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml b/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml >> new file mode 100644 >> index 000000000000..61ed6dc7740b >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml >> @@ -0,0 +1,123 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/display/bridge/ite,it66121.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: ITE it66121 HDMI bridge Device Tree Bindings >> + >> +maintainers: >> + - Phong LE >> + - Neil Armstrong >> + >> +description: | >> + The IT66121 is a high-performance and low-power single channel HDMI >> + transmitter, fully compliant with HDMI 1.3a, HDCP 1.2 and backward compatible >> + to DVI 1.0 specifications. >> + >> +properties: >> + compatible: >> + const: ite,it66121 >> + >> + reg: >> + maxItems: 1 >> + description: base I2C address of the device > > You can drop the description. Done > >> + >> + reset-gpios: >> + maxItems: 1 >> + description: GPIO connected to active low reset >> + >> + vrf12-supply: >> + description: Regulator for 1.2V analog core power. >> + >> + vcn33-supply: >> + description: Regulator for 3.3V digital core power. >> + >> + vcn18-supply: >> + description: Regulator for 1.8V IO core power. >> + >> + interrupts: >> + maxItems: 1 >> + >> + ports: >> + $ref: /schemas/graph.yaml#/properties/ports >> + >> + properties: >> + port@0: >> + $ref: /schemas/graph.yaml#/$defs/port-base >> + unevaluatedProperties: false >> + description: DPI input port. >> + >> + properties: >> + endpoint: >> + $ref: /schemas/graph.yaml#/$defs/endpoint-base >> + unevaluatedProperties: false >> + >> + properties: >> + bus-width: >> + description: >> + Endpoint bus width. >> + enum: >> + - 12 # 12 data lines connected and dual-edge mode >> + - 24 # 24 data lines connected and single-edge mode >> + default: 24 >> + >> + port@1: >> + $ref: /schemas/graph.yaml#/properties/port >> + description: HDMI Connector port. >> + >> + required: >> + - port@0 >> + - port@1 >> + >> +required: >> + - compatible >> + - reg >> + - reset-gpios >> + - vrf12-supply >> + - vcn33-supply >> + - vcn18-supply >> + - interrupts >> + - ports >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + i2c { >> + #address-cells = <1>; >> + #size-cells = <0>; > > It's customary to indent DT examples with 4 spaces. Done > >> + >> + it66121hdmitx: it66121hdmitx@4c { >> + compatible = "ite,it66121"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&ite_pins_default>; >> + vcn33-supply = <&mt6358_vcn33_wifi_reg>; >> + vcn18-supply = <&mt6358_vcn18_reg>; >> + vrf12-supply = <&mt6358_vrf12_reg>; >> + reset-gpios = <&pio 160 1 /* GPIO_ACTIVE_LOW */>; > > You can #include the necessary headers at the top of the example, and > use GPIO_ACTIVE_LOW and IRQ_TYPE_LEVEL_LOW to replace the numerical > values. Done > > Reviewed-by: Laurent Pinchart Thanks, Neil > >> + interrupt-parent = <&pio>; >> + interrupts = <4 8 /* IRQ_TYPE_LEVEL_LOW */>; >> + reg = <0x4c>; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + reg = <0>; >> + it66121_in: endpoint { >> + bus-width = <12>; >> + remote-endpoint = <&display_out>; >> + }; >> + }; >> + >> + port@1 { >> + reg = <1>; >> + hdmi_conn_out: endpoint { >> + remote-endpoint = <&hdmi_conn_in>; >> + }; >> + }; >> + }; >> + }; >> + }; >