From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31F53C77B7A for ; Thu, 25 May 2023 09:08:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240548AbjEYJIj (ORCPT ); Thu, 25 May 2023 05:08:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229912AbjEYJIh (ORCPT ); Thu, 25 May 2023 05:08:37 -0400 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D5F11A2; Thu, 25 May 2023 02:08:33 -0700 (PDT) Received: (Authenticated sender: alexis.lothore@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 22A442000F; Thu, 25 May 2023 09:08:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1685005711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eaf0f8on8F0v4A7b8O5FkakZD4TKew8S3VzKcKXRadk=; b=pVnJ1YtyiSFpg6kxr4CkL4foygOhrmaV6OYJpNSfsWd3UTVsQom+k9LVU7Se4IyoPQ+pL7 bYbWl2KDjhFbQm6UuFxui6JQBiGqoxCzQ11cdWVjFwBH2kci+uv62Yqr8FNklzt/y2ePdL jwT+VkqeU1AXZaF9H1kU+eOu6CQvd9uTnOi2x6rTaDjlrJ3yKIixhmo4gCKFiz6uMDGRnK rdzIvWdO8BAnuBnMg9xamY8Nx6tpfIHjxFsaItQehmpWjAME1osCqW1lQ9A5eB3BAO95LD bfQ2xQWochtkznHYzo3LG254v7s7jTl0pOv33vluWdinQTU8EhsjK3f12kz44w== Message-ID: <7126e538-0cac-fe1b-fc89-0a4c9e2afcde@bootlin.com> Date: Thu, 25 May 2023 11:08:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH net-next v3 2/7] net: dsa: mv88e6xxx: pass directly chip structure to mv88e6xxx_phy_is_internal Content-Language: en-US To: Andrew Lunn Cc: "Russell King (Oracle)" , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, Thomas Petazzoni , paul.arola@telus.com, scott.roberts@telus.com, =?UTF-8?Q?Marek_Beh=c3=ban?= References: <20230524130127.268201-1-alexis.lothore@bootlin.com> <20230524130127.268201-3-alexis.lothore@bootlin.com> <9a7fac7b-e04b-27e2-8679-ffbbb23c248e@bootlin.com> <325a6737-21b9-4b78-b022-9a540c3c0f33@lunn.ch> From: =?UTF-8?Q?Alexis_Lothor=c3=a9?= In-Reply-To: <325a6737-21b9-4b78-b022-9a540c3c0f33@lunn.ch> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/24/23 19:08, Andrew Lunn wrote: > On Wed, May 24, 2023 at 04:46:35PM +0200, Alexis Lothoré wrote: >> Hello Russell, >> >> On 5/24/23 15:18, Russell King (Oracle) wrote: >>> On Wed, May 24, 2023 at 03:01:22PM +0200, Alexis Lothoré wrote: >>>> Since this function is a simple helper, we do not need to pass a full >>>> dsa_switch structure, we can directly pass the mv88e6xxx_chip structure. >>>> Doing so will allow to share this function with any other function >>>> not manipulating dsa_switch structure but needing info about number of >>>> internal phys >>>> >>>> Reviewed-by: Russell King (Oracle) >>>> Reviewed-by: Florian Fainelli >>>> >>>> --- >>>> Changes since v2: >>>> - add reviewed-by tags >>>> >>>> Signed-off-by: Alexis Lothoré >>>> --- >>> >>> It never ceases to amaze me the way human beings can find creative ways >>> to mess things up, no matter how well things are documented. The above >>> commit message (and the others that I've looked at) are all broken >>> because of this creativity. >>> >>> In effect, because of the really weird format you've come up with here, >>> your patches are in effect *not* signed off by you. >> >> Sorry for that. This was an attempt to provide relevant changelog for each >> patch, but obviously the way I stored those changelogs was wrong, and I did not >> catch the consequent broken Signed-off-by lines after re-generating the series. >> I'll do as suggested and hold off a bit before fixing/re-sending. > > You can put the changelog in the commit message in git commit, you > just need to add the correct --- separate after the tags. The patch > created with git format-patch will then have two ---, but that is not > a problem. Yes, that is exactly what I intended to do, but digging a bit, I guess the issue has been that my current configuration relies on git format-patch to insert my SoB, and it seems to not identify the marker so it inserts the SoB after it instead of before. Looks like it was broken in the series v2 too. Fixed my configuration to sign-off right at commit time. Thanks > > Andrew > > --- > pw-bot: cr -- Alexis Lothoré, Bootlin Embedded Linux and Kernel engineering https://bootlin.com