From: David Oberhollenzer <david.oberhollenzer@sigma-star.at>
To: Heiko Schocher <hs@denx.de>, linux-mtd@lists.infradead.org
Cc: Artem Bityutskiy <dedekind1@gmail.com>,
Richard Weinberger <richard@nod.at>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-kernel@vger.kernel.org,
Masahiro Yamada <yamada.masahiro@socionext.com>
Subject: Re: [PATCH v2] ubifs: compress lines for immediate return
Date: Mon, 5 Sep 2016 15:18:40 +0200 [thread overview]
Message-ID: <71387535-39e5-9cbc-71c4-d5142e409110@sigma-star.at> (raw)
In-Reply-To: <1473058466-10831-1-git-send-email-hs@denx.de>
On 09/05/2016 08:54 AM, Heiko Schocher wrote:
> diff --git a/fs/ubifs/budget.c b/fs/ubifs/budget.c
> index 11a11b3..48d6851 100644
> --- a/fs/ubifs/budget.c
> +++ b/fs/ubifs/budget.c
> @@ -77,7 +77,7 @@ static void shrink_liability(struct ubifs_info *c, int nr_to_write)
> */
> static int run_gc(struct ubifs_info *c)
> {
> - int err, lnum;
> + int lnum;
>
> /* Make some free space by garbage-collecting dirty space */
> down_read(&c->commit_sem);
> @@ -88,10 +88,7 @@ static int run_gc(struct ubifs_info *c)
>
> /* GC freed one LEB, return it to lprops */
> dbg_budg("GC freed LEB %d", lnum);
> - err = ubifs_return_leb(c, lnum);
> - if (err)
> - return err;
> - return 0;
> + return = ubifs_return_leb(c, lnum);
> }
>
Apart from the other issues discussed below and in v1, I don't
believe that this _ever_ compiled successfully.
next prev parent reply other threads:[~2016-09-05 13:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 6:54 [PATCH v2] ubifs: compress lines for immediate return Heiko Schocher
2016-09-05 12:44 ` Masahiro Yamada
2016-09-05 13:05 ` Heiko Schocher
2016-09-05 13:32 ` Richard Weinberger
2016-09-06 4:37 ` Heiko Schocher
2016-09-05 13:18 ` David Oberhollenzer [this message]
2016-09-05 13:26 ` Masahiro Yamada
2016-09-10 23:29 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71387535-39e5-9cbc-71c4-d5142e409110@sigma-star.at \
--to=david.oberhollenzer@sigma-star.at \
--cc=adrian.hunter@intel.com \
--cc=dedekind1@gmail.com \
--cc=hs@denx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).