From: Joe Perches <joe@perches.com>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH] checkpatch: Warn if DT bindings are not in schema format
Date: Fri, 13 Sep 2019 14:48:49 -0700 [thread overview]
Message-ID: <713b2e5bbab16ddf850245ae1d92be66d9730e02.camel@perches.com> (raw)
In-Reply-To: <20190913211349.28245-1-robh@kernel.org>
On Fri, 2019-09-13 at 16:13 -0500, Rob Herring wrote:
> DT bindings are moving to using a json-schema based schema format
> instead of freeform text. Add a checkpatch.pl check to encourage using
> the schema for new bindings. It's not yet a requirement, but is
> progressively being required by some maintainers.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -2822,6 +2822,14 @@ sub process {
> "added, moved or deleted file(s), does MAINTAINERS need updating?\n" . $herecurr);
> }
>
> +# Check for adding new DT bindings not in schema format
> + if (!$in_commit_log &&
> + ($line =~ /^new file mode\s*\d+\s*$/) &&
> + ($realfile =~ m@^Documentation/devicetree/bindings/.*\.txt$@)) {
> + WARN("DT_SCHEMA_BINDING_PATCH",
> + "DT bindings should be in DT schema format. See: Documentation/devicetree/writing-schema.rst\n");
> + }
> +
As this already seems to be git dependent, perhaps
it's easier to read with a single line test like:
if ($line =~ m{^\s*create mode\s*\d+\s*Documentation/devicetree/bindings/.*\.txt$}) {
etc...
}
There are ~3500 existing .txt files:
$ git ls-files -- 'Documentation/devicetree/bindings/*.txt' | wc -l
3476
Are these going to be converted somehow?
What about files like these? (not .txt)
Documentation/devicetree/bindings/timer/st,stih407-lpc
Documentation/devicetree/bindings/nds32/andestech-boards
Documentation/devicetree/bindings/media/nokia,n900-ir
Documentation/devicetree/bindings/interrupt-controller/ti,omap4-wugen-mpu
Documentation/devicetree/bindings/arm/cpu-enable-method/nuvoton,npcm750-smp
Documentation/devicetree/bindings/arm/cpu-enable-method/marvell,berlin-smp
Documentation/devicetree/bindings/arm/cpu-enable-method/al,alpine-smp
Documentation/devicetree/bindings/arm/arm-boards
next prev parent reply other threads:[~2019-09-13 21:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 21:13 [PATCH] checkpatch: Warn if DT bindings are not in schema format Rob Herring
2019-09-13 21:48 ` Joe Perches [this message]
2019-09-16 18:21 ` Rob Herring
2019-09-27 14:02 ` Rob Herring
2019-09-27 14:29 ` Joe Perches
2019-09-27 15:39 ` Rob Herring
2019-10-11 17:56 ` Rob Herring
2019-10-11 18:02 ` Joe Perches
2019-10-11 19:32 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=713b2e5bbab16ddf850245ae1d92be66d9730e02.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).